High-res FOTA animation assets HOWTO?

[emeric....@gmail.com]

Hi,

Warning: Pure cosmetic detail inside!

In Flame's v18D base image, FOTA animation assets are FWVGA-sized.
In Flame's v18D_nightly_v{4|5} base image, FOTA animation assets are 320x480 pixels in size.

v18D base image was built by T²Mobile.
v18D_nightly_v{4|5} base image was built by Mozilla.

FOTA animation assets come from platform_bootable_recovery repository [1]. Well, not exactly, in fact ;-) Per bug #803549 [2], it was decided to symlink FOTA assets there to librecovery repository [3] one's.

Original 320x480 pixels artwork was pushed in librecovery repository in commit e1bd900 [4] four years ago. Nothing's changed since then. All private builds of B2G OS devices relying upon librecovery will thus end up with 320x480 pixels assets.

Question is thus: What's a clean way to embed high-res FOTA assets in private builds? For example for Flame device, does it mean that T²Mobile forked librecovery repository, replacing the original 320x480 pixels artwork with FWVGA one? Isn't there a less invasive way to do this, maybe using some magic in each device repository? Using the TARGET_RECOVERY_UI_LIB thing?

The only device that seems to play with FOTA assets is unagi [5]. But its BoardConfig.mk doesn't enable librecovery build, so unagi seems to rely on its own librecovery fork. Looking at bug #803549 again, it appears that unagi device was ready before librecovery landed. unagi configuration should have been updated following the landing of librecovery [6], but this wasn't the case in the end.

So, the question is still open ;-)

Émeric


[1] https://github.com/mozilla-b2g/platform_bootable_recovery
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=803549
[3] https://github.com/mozilla-b2g/librecovery
[4] https://github.com/mozilla-b2g/librecovery/commit/e1bd90051c9e937221eb1f91c94e3cde747311a7
[5] https://github.com/mozilla-b2g/android-device-unagi
[6] https://bugzilla.mozilla.org/show_bug.cgi?id=803549#c20

[Seinlin Li]

2016-12-30 6:50 GMT+08:00 <emeric....@gmail.com>:

Hi,

Warning: Pure cosmetic detail inside!

In Flame's v18D base image, FOTA animation assets are FWVGA-sized.
In Flame's v18D_nightly_v{4|5} base image, FOTA animation assets are 320x480 pixels in size.

v18D base image was built by T²Mobile.
v18D_nightly_v{4|5} base image was built by Mozilla.

FOTA animation assets come from platform_bootable_recovery repository [1]. Well, not exactly, in fact ;-) Per bug #803549 [2], it was decided to symlink FOTA assets there to librecovery repository [3] one's.

Original 320x480 pixels artwork was pushed in librecovery repository in commit e1bd900 [4] four years ago. Nothing's changed since then. All private builds of B2G OS devices relying upon librecovery will thus end up with 320x480 pixels assets.

Question is thus: What's a clean way to embed high-res FOTA assets in private builds? For example for Flame device, does it mean that T²Mobile forked librecovery repository, replacing the original 320x480 pixels artwork with FWVGA one? Isn't there a less invasive way to do this, maybe using some magic in each device repository? Using the TARGET_RECOVERY_UI_LIB thing?

 

I think you are right, when TARGET_RECOVERY_UI_LIB is exported from device config it will be used.

 

The only device that seems to play with FOTA assets is unagi [5]. But its BoardConfig.mk doesn't enable librecovery build, so unagi seems to rely on its own librecovery fork. Looking at bug #803549 again, it appears that unagi device was ready before librecovery landed. unagi configuration should have been updated following the landing of librecovery [6], but this wasn't the case in the end.

In unagi, TARGET_RECOVERY_UI_LIB is exported in

https://github.com/mozilla-b2g/android-device-unagi/blob/master/BoardConfig.mk#L5

And 'librecovery_ui_fxos' is defined in.

https://github.com/mozilla-b2g/android-device-unagi/blob/master/recovery/Android.mk#L20

 

So unagi doesn't use animation from librecovery, but it use the one define in android-device-unagi[5].

So, the question is still open ;-)

     Émeric


[1] https://github.com/mozilla-b2g/platform_bootable_recovery
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=803549
[3] https://github.com/mozilla-b2g/librecovery
[4] https://github.com/mozilla-b2g/librecovery/commit/e1bd90051c9e937221eb1f91c94e3cde747311a7
[5] https://github.com/mozilla-b2g/android-device-unagi
[6] https://bugzilla.mozilla.org/show_bug.cgi?id=803549#c20

_______________________________________________
dev-fxos mailing list
dev-...@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-fxos

[Émeric MASCHINO]

2016-12-30 5:00 GMT+01:00 Seinlin Li <seinli...@gmail.com>:
>
> I think you are right, when TARGET_RECOVERY_UI_LIB is exported from device
> config it will be used.

Well, it was even easier than what I thought!

For Flame device, you'll just have to add the high-res FOTA assets
(retrieved from v18D recovery.img) in device-flame/recovery/res/images
and the underlying FFOS/Android buildsystem magic will do the rest :-)

Émeric