Broken blobs extraction system with homonym files

[emeric....@gmail.com]

Hi,

extract-files.sh script that pulls proprietary blobs from device doesn't work correctly when files with the same name are found in different paths on device.

Indeed, extract-files.sh script pulls blobs from device and puts them _flat_ in B2G/$MANUFACTURER/$DEVICE/proprietary directory. Hence, both system/b2g/distribution/bundles/b2g_time/chrome.manifest and system/b2g/distribution/bundles/telephony/chrome.manifest files would be pulled as B2G/$MANUFACTURER/$DEVICE/proprietary directory/chrome.manifest file, this last one obviously being the latter copied. Next, the autogenerated B2G/$MANUFACTURER/$DEVICE/$DEVICE-vendor-blobs.mk script correctly recreates the device's hierarchy, but the various chrome.manifest files in different paths are all copied back from the unique B2G/$MANUFACTURER/$DEVICE/proprietary/chrome.manifest one and are thus now all identical!

Any idea how this can be fixed properly without breaking the extract-files.sh / B2G/$MANUFACTURER/$DEVICE/$DEVICE-vendor-blobs.mk couple?

Thanks,

Émeric

[Alexandre Lissy]

On 31/05/2016 01:53, emeric....@gmail.com wrote:
> Hi,
>
> extract-files.sh script that pulls proprietary blobs from device doesn't work correctly when files with the same name are found in different paths on device.
>
> Indeed, extract-files.sh script pulls blobs from device and puts them _flat_ in B2G/$MANUFACTURER/$DEVICE/proprietary directory. Hence, both system/b2g/distribution/bundles/b2g_time/chrome.manifest and system/b2g/distribution/bundles/telephony/chrome.manifest files would be pulled as B2G/$MANUFACTURER/$DEVICE/proprietary directory/chrome.manifest file, this last one obviously being the latter copied. Next, the autogenerated B2G/$MANUFACTURER/$DEVICE/$DEVICE-vendor-blobs.mk script correctly recreates the device's hierarchy, but the various chrome.manifest files in different paths are all copied back from the unique B2G/$MANUFACTURER/$DEVICE/proprietary/chrome.manifest one and are thus now all identical!

Thing is, those components are likely not to work/being pushed back on
the device because they are XPCOM that will break with new Gecko.

>
> Any idea how this can be fixed properly without breaking the extract-files.sh / B2G/$MANUFACTURER/$DEVICE/$DEVICE-vendor-blobs.mk couple?

Anything that works is good :)

>
> Thanks,
>
> Émeric
> _______________________________________________
> dev-fxos mailing list
> dev-...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-fxos
>

[emeric....@gmail.com]

Le mardi 31 mai 2016 10:27:39 UTC+2, Alexandre Lissy a écrit :
>

<snip>

> > Any idea how this can be fixed properly without breaking the extract-files.sh / B2G/$MANUFACTURER/$DEVICE/$DEVICE-vendor-blobs.mk couple?
>
> Anything that works is good :)

Nevermind, copy_files and copy_files_glob functions in extract-files.sh do work as expected. They can take an optional folder name as last argument. Just use it ;-)

Émeric