Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

XPI validation -- Global variable overwrite

48 views
Skip to first unread message

gNeandr

unread,
Aug 7, 2012, 7:34:01 AM8/7/12
to
Here is another AMO Validation report warning:

> Global variable overwrite
>
> Warning: An attempt was made to overwrite a global variable in some JavaScript code.
> chrome/reminderfox.jar/content/reminderfox/calendar/calendarWidget.js
>
> window.outerWidth = document.documentElement.attributes[id+"_width"].value;
> window.outerHeight = document.documentElement.attributes[id+"_height"].value;

Any serious problem here?

Neil

unread,
Aug 7, 2012, 9:38:04 AM8/7/12
to
Using resizeTo would be more efficient anyway. (I presume there is a
reason why you can't just persist the width and height directly?)

--
Warning: May contain traces of nuts.

gNeandr

unread,
Aug 7, 2012, 10:55:26 AM8/7/12
to
You're right. The point here is the content is very variable, so it's
important the user finds his own favorite size by using the dialog
handles. And because there are different contents/layouts I have to save
the sizing parameters to switch between the user's layouts/sizings.

0 new messages