[Bug 413385] Implement Customizable Toolbars in SeaMonkey MailNews

1 view
Skip to first unread message

Philip Chee

unread,
Mar 23, 2009, 4:46:22 AM3/23/09
to
I've started on customizable toolbars for SeaMonkey MailNews. Much of it
is mechanical refactoring however there are some design issues that I
need feedback on.

The mark and delete buttons never appear together. Depending on whether
the focus is on a mail message or a news message, one or the other will
be hidden. This makes it hard for the user to drag (an invisible) button
when in customize mode.

One way to deal with this is to make both buttons visible all the time
and just enable/disable the buttons instead of hiding them.

Another way would be to forcibly unhide the buttons when going into
customize mode; and then update/reset the buttons on exiting.

Thoughts? Ideas? What does Thunderbird do?

Phil

--
Philip Chee <phi...@aleytys.pc.my>, <phili...@gmail.com>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.
[ ]My software never has bugs. It just develops random features...
* TagZilla 0.066.6

Neil

unread,
Mar 23, 2009, 7:23:36 AM3/23/09
to
Philip Chee wrote:

>What does Thunderbird do?
>
>
a) Thunderbird never hides the Mark button
b) It looks as if you're out of luck when you're reading news.

I like the idea of unhiding the Delete button while customising (maybe
via CSS toolbarpaletteitem > #button-delete { display: -moz-box; } ).

--
Warning: May contain traces of nuts.

Robert Kaiser

unread,
Mar 23, 2009, 8:40:54 AM3/23/09
to
Philip Chee wrote:
> One way to deal with this is to make both buttons visible all the time
> and just enable/disable the buttons instead of hiding them.

Actually, I think the mark button could be displayed all the time and
active when the Message > Mark menu is activated as well (which is even
true for mail).

> Another way would be to forcibly unhide the buttons when going into
> customize mode; and then update/reset the buttons on exiting.

I'd very much prefer that - I actually wonder that this isn't general
practice of customizing, but probably everyone's so proud of all their
buttons cluttering the interface that usually nobody hides them ;-)

Robert Kaiser

Philip Chee

unread,
Mar 23, 2009, 2:49:24 PM3/23/09
to
On Mon, 23 Mar 2009 13:40:54 +0100, Robert Kaiser wrote:
> Philip Chee wrote:
>> One way to deal with this is to make both buttons visible all the time
>> and just enable/disable the buttons instead of hiding them.
>
> Actually, I think the mark button could be displayed all the time and
> active when the Message > Mark menu is activated as well (which is even
> true for mail).

I think I agree with you on this.

>> Another way would be to forcibly unhide the buttons when going into
>> customize mode; and then update/reset the buttons on exiting.
>
> I'd very much prefer that - I actually wonder that this isn't general
> practice of customizing, but probably everyone's so proud of all their
> buttons cluttering the interface that usually nobody hides them ;-)

Looking at the sanitize code in customizeToolbars.js it looks like it
deals with a few other attributes but not hidden so it looks like a
usecase that no other toolkit application needs.

Phil

--
Philip Chee <phi...@aleytys.pc.my>, <phili...@gmail.com>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.

[ ]My computer's sick. I think my modem is a carrier.
* TagZilla 0.066.6

Philip Chee

unread,
Mar 23, 2009, 2:52:24 PM3/23/09
to
On Mon, 23 Mar 2009 11:23:36 +0000, Neil wrote:
> Philip Chee wrote:
>
>>What does Thunderbird do?
>>
>>
> a) Thunderbird never hides the Mark button
> b) It looks as if you're out of luck when you're reading news.
>
> I like the idea of unhiding the Delete button while customising (maybe
> via CSS toolbarpaletteitem > #button-delete { display: -moz-box; } ).

This sounds like an elegant solution, but does the CSS win out over
element.hidden?

Phil

--
Philip Chee <phi...@aleytys.pc.my>, <phili...@gmail.com>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.

[ ]Self-deceit is easy; what one wishes one believes is true
* TagZilla 0.066.6

Neil

unread,
Mar 24, 2009, 5:26:06 AM3/24/09
to
Philip Chee wrote:

>On Mon, 23 Mar 2009 11:23:36 +0000, Neil wrote:
>
>
>>Philip Chee wrote:
>>
>>>What does Thunderbird do?
>>>
>>a) Thunderbird never hides the Mark button
>>b) It looks as if you're out of luck when you're reading news.
>>
>>I like the idea of unhiding the Delete button while customising (maybe
>>via CSS toolbarpaletteitem > #button-delete { display: -moz-box; } ).
>>
>>
>This sounds like an elegant solution, but does the CSS win out over element.hidden?
>
>

It should do if it's specific enough, since hidden is just a CSS rule in
xul.css

Stanimir Stamenkov

unread,
Mar 24, 2009, 7:21:19 PM3/24/09
to
Mon, 23 Mar 2009 16:46:22 +0800, /Philip Chee/:

> Another way would be to forcibly unhide the buttons when going into
> customize mode; and then update/reset the buttons on exiting.

I use the following style in my "userChrome.css":

Combine Stop/Reload buttons <http://userstyles.org/styles/10>

which hides one or the other of the Stop and Reload buttons, and I
get both buttons visible when in customize mode.

--
Stanimir

Philip Chee

unread,
Apr 24, 2009, 12:42:52 PM4/24/09
to
Hi!

Just a note to our nightly testers. Customizable Toolbars in MailNews
has landed. The show hide prefrences have been removed from the
Preferences window. To add or remove buttons to the toolbar, right click
on the mailnews toolbar and select "Customize..." then start dragging
buttons around. You can drop them on any toolbar (in the toolbox)
including the menubar.

If you see any weirdness including a totally missing toolbar then try
shutting down SeaMonkey 2.0b1pre and deleting/renaming localstore.rdf in
your profile.

Phil

--
Philip Chee <phi...@aleytys.pc.my>, <phili...@gmail.com>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.

[ ]Not a real tagline, but an incredible soy substitute.
* TagZilla 0.066.6

NoOp

unread,
Apr 24, 2009, 10:48:06 PM4/24/09
to
On 04/24/2009 09:42 AM, Philip Chee wrote:
> Hi!
>
> Just a note to our nightly testers. Customizable Toolbars in MailNews
> has landed. The show hide prefrences have been removed from the
> Preferences window. To add or remove buttons to the toolbar, right click
> on the mailnews toolbar and select "Customize..." then start dragging
> buttons around. You can drop them on any toolbar (in the toolbox)
> including the menubar.
>
> If you see any weirdness including a totally missing toolbar then try
> shutting down SeaMonkey 2.0b1pre and deleting/renaming localstore.rdf in
> your profile.
>
> Phil
>

Build identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b4pre)
Gecko/20090409 SeaMonkey/2.0b1pre

Not working for me - unless I'm not clicking in the proper location.

Barry Edwin Gilmour

unread,
Apr 24, 2009, 11:19:45 PM4/24/09
to
Bug 413385 -
<https://bugzilla.mozilla.org/show_bug.cgi?id=413385>(RESOLVED FIXED)
Implement Customizable Toolbars in SeaMonkey MailNews
<https://bugzilla.mozilla.org/show_bug.cgi?id=413385>
Gary, I think you missed the date of Phil's message. It was working
correctly in last-night's build and again in tonight's edition..
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b5pre) Gecko/20090424
Lightning/1.0pre SeaMonkey/2.0b1pre ID:20090424000648
on Mandriva-Linux-2008.1-PowerPack kernel-2.6.24.7-2 2008-10-30 i686
Intel(R) Pentium(R) 4 CPU 2.53GHz GNU/Linux. Barry

NoOp

unread,
Apr 25, 2009, 1:27:16 PM4/25/09
to

My updates hadn't been working & I was stuck at 20090409. I've
reinstalled with the latest nightly & the toolbar is working for me now.
Sorry for the noise.

Gary

Reply all
Reply to author
Forward
0 new messages