Re: release candidates and api changes

[Philip Chee]

On Fri, 30 Oct 2009 14:50:42 +0100, gNeandr wrote:

> Just to add: with ReminderFox next release we will have some new
> features around TB 3/AB using some of the new API. It's working well
> since weeks with TB3.0b4 but also with TB3.0pre.
> G�nter

Is ReminderFox working well with SeaMonkey 2.0? I only implemented a
minimum subset of gFolderDisplay in SeaMonkey to support Lightning and
Enigmail. If there is anything missing in SeaMonkey 2.0 that ReminderFox
needs, please let me know.

Phil

--
Philip Chee <phi...@aleytys.pc.my>, <phili...@gmail.com>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.

[gNeandr]

[31.10.2009 03:50] �Philip Chee� wrote:
> On Fri, 30 Oct 2009 14:50:42 +0100, gNeandr wrote:
>
>
>> Just to add: with ReminderFox next release we will have some new
>> features around TB 3/AB using some of the new API. It's working well
>> since weeks with TB3.0b4 but also with TB3.0pre.
>> G�nter
>>
> Is ReminderFox working well with SeaMonkey 2.0? I only implemented a
> minimum subset of gFolderDisplay in SeaMonkey to support Lightning and
> Enigmail. If there is anything missing in SeaMonkey 2.0 that ReminderFox
> needs, please let me know.
>
> Phi

Thanks Phil to remind me about the compatibility of SM2 with ReminderFox.
Currently it's not with the SM2 release. Just checked and noticed SM2
already has the TB3/AB code running. For that I have to update ReminderFox.
Hope to have it ready for the 1.9.5 release we are planning in November.
Will call back for this.
G�nter

[gNeandr]

Hi Phil,

yes need help !!

With TB I have this code:

var newReminderToBeAdded = new ReminderFoxEvent
( rmFx_SwRm_Reference, newDate, mailIdentifierString + " " +
gMsgSubjectElement.value );

This is to access the Subject which was entered during a compose. The
'gMsgSubjectElement.value' has correct value with
TB2/ and TB3, but not with SM2.

Any help for that??

G�nter

[Jens Hatlak]

gNeandr wrote:
> With TB I have this code:
>
> var newReminderToBeAdded = new ReminderFoxEvent
> ( rmFx_SwRm_Reference, newDate, mailIdentifierString + " " +
> gMsgSubjectElement.value );
>
> This is to access the Subject which was entered during a compose. The
> 'gMsgSubjectElement.value' has correct value with
> TB2/ and TB3, but not with SM2.

SM2 has the same variable, accessing the same element [1] so I don't see
why .value doesn't work for you; in fact,
top.opener.gMsgSubjectElement.value will give you the subject in the
Error Console opened from a compose window. Maybe you need to change
some overlays to work with SM, I don't know (haven't looked at your
extension, only at this example).

[1]
<http://mxr.mozilla.org/comm-1.9.1/search?string=gMsgSubjectElement&case=on>

Greetings,

Jens

--
Jens Hatlak <http://jens.hatlak.de/>
SeaMonkey Trunk Tracker <http://smtt.blogspot.com/>

[gNeandr]

[31.10.2009 20:35] �Jens Hatlak� wrote:
> gNeandr wrote:
>> With TB I have this code:
>>
>> var newReminderToBeAdded = new ReminderFoxEvent
>> ( rmFx_SwRm_Reference, newDate, mailIdentifierString + " " +
>> gMsgSubjectElement.value );
>>
>> This is to access the Subject which was entered during a compose. The
>> 'gMsgSubjectElement.value' has correct value with
>> TB2/ and TB3, but not with SM2.
>
> SM2 has the same variable, accessing the same element [1] so I don't
> see why .value doesn't work for you; in fact,
> top.opener.gMsgSubjectElement.value will give you the subject in the
> Error Console opened from a compose window. Maybe you need to change
> some overlays to work with SM, I don't know (haven't looked at your
> extension, only at this example).
>
> [1]
> <http://mxr.mozilla.org/comm-1.9.1/search?string=gMsgSubjectElement&case=on>
>
>
> Greetings,
>
> Jens
>

The function including that gMsgSubjectElement.value is called form a
toolbar menu item which has been 'customized' with a toolbarpalette.
Same as with TB (and Postbox!):

<!-- Thunderbird compose -->
<toolbarpalette id="MsgComposeToolbarPalette">
<toolbarbutton id="rmFx_SendPlus"
label="&mail.send.withreminder; ++"
tooltiptext="&mail.send.withreminder.tooltip;"
oncommand="rmFx_msgSendwReminder();"
class="toolbarbutton-1 chromeclass-toolbar-additional
rmFx_SendPlus"
/>

Using that menu button the function rmFx_msgSendwReminder(); gets called
(as it is with TB/PB).
With the debugger I can follow the steps just before the mentioned line.
The global variable 'gMsgSubjectElement' gives:
0001: this.gMsgSubjectElement $[0] = [void] void

Note: if I disable that access to the subject of the msg to be send
(gMsgSubjectElement.value deleted from the string) the function does well.

Any additional help??

[gNeandr]

[01.11.2009 01:49] �Neil� wrote:

> gNeandr wrote:
>
>> This is to access the Subject which was entered during a compose. The
>> 'gMsgSubjectElement.value' has correct value with
>> TB2/ and TB3, but not with SM2.
>>
>> Any help for that??
>

> Try using GetMsgSubjectElement().value instead. Thunderbird fixed
> their code to use this instead of calling document.getElementById all
> the time, which means that as a side-effect that the
> gMsgSubjectElement.value is already set, but SeaMonkey only sets it if
> you press Ctrl+Tab.
>
Thanks, that does it!
A step closer to make ReminderFox compatible with SM2 ;-)