Re: The State of Tab Candy | 10 Aug 2010

0 views
Skip to first unread message

Mike Beltzner

unread,
Aug 11, 2010, 3:02:38 AM8/11/10
to Aza, Paul O’Shannessy, Ehsan Akhgari, Edward Lee, Gavin Sharp, Mayumi Matsuno, L. David Baron, Johnathan Nightingale, Dão Gottwald, Juan Becerra, Tracy Demiroz, Atul Varma, mitcho (Michael 芳貴 Erlewine), Ian Gilman, dev-apps-firefox, Raymond Lee, Justin Dolske
Hey everyone,

I've been following along closely today, impressed with how things are marching forward. To clarify: if we can get the four patches reviewed below, the additional "blocking bugs" aren't required for it to land on mozilla-central, but would then be required before the beta 4 code freeze? Do we have an estimation of whether those bugs are close or far away?

cheers,
mike

On 2010-08-10, at 11:41 PM, Aza wrote:

> == Aug 10 2010 ==
>
> Current Goal: Land on trunk by Wed night.
>
> Things are looking up for Tab Candy to land in beta 4. The addition of Ehsan to the team (thanks to Roc's blessings) have really pushed things forward especially in Ts. Mitcho has done a great job of fixing review comments as they come up, Ian Gilman has got our architecture humming, Mardak is spinning patches with deft fingers, and Raymond Lee is making our unit tests robust.
>
> Unfortunately, Mitcho and Ehsan are unavailable on Thursday meaning that most of the work has to be done by Wednesday evening. Our goal is to land by then. Landing Friday is out of the question as we need to let this major new feature have time to bake.
>
> The overview of what we need to do is:
>
> 1. Be within a 2% Ts regression, with a plan how to reduce that number to 0.
> Ehsan did some heroics here to accomplish this feat.
> https://bugzilla.mozilla.org/show_bug.cgi?id=583388 [DONE!]
> 2. Have tests for the modifications that we've made to the browser code.
> https://bugzilla.mozilla.org/show_bug.cgi?id=577321 [Raymond: ON TRACK]
> 3. Have reviews on the patches. We need Dao's help here. [HIGHEST RISK: See below]
>
> == Needing Review ==
>
> Our biggest risk is that we won't get the reviews back from Dao in time.
>
> * Land Tab Candy Utility Code (iq.js)
> We've gone through a round of reviews with Gavin and then Dao. We appear
> to be in the nitpick stage. We need final approval ASAP.
> https://bugzilla.mozilla.org/show_bug.cgi?id=582023 [Needs Dao's r+]
> * Provide a way to show certain tabs and get visible tabs.
> Gavin also did a round of reviews but asked Dao to weigh in. We also
> appear to be in the nitpick stage. Need final approval ASAP.
> https://bugzilla.mozilla.org/show_bug.cgi?id=582116 [Needs Dao's r+]
> * Restore visible tabs (and hide hidden ones)
> Mardak has put up a very small patch with unit tests. Waiting for Paul.
> https://bugzilla.mozilla.org/show_bug.cgi?id=586147 [Needs Zpao's r+]
> * Review the Tab Candy core (Land Tab Candy on Trunk)
> Dolske has been doing an heroic job of reviewing our code. He's got "just" the self-
> contained bits in browser/base/content/tabview left to do. He's optimistic it can
> be done.
> https://bugzilla.mozilla.org/show_bug.cgi?id=574217 [Needs Dolske's r+]
>
> == Blocking Bugs ==
>
> * Title and Tab Bars or the Menu and Tab Bars to appear solid black with Tab Candy
> Atul reports that removing the iframe dynamically via DOMi removes the
> black, as does adding "display:none".
> https://bugzilla.mozilla.org/show_bug.cgi?id=581813 [Iangilman]
> * Interpolation out-of-range assertion for Tab Candy Style Animation
> Dbaron is currently trying to land his patch:
> https://bugzilla.mozilla.org/show_bug.cgi?id=575672 [Dbaron]
>
> == Unit Tests ==
>
> * Test tab previews in presence of Tab Candy
> https://bugzilla.mozilla.org/show_bug.cgi?id=585854 [Raymond]
>
> == Things to Keep An Eye On ==
>
> * We are currently have some issues around the bookmarks all tab command.
> Not enough to block, but something to keep an eye on.
> https://bugzilla.mozilla.org/show_bug.cgi?id=585855#c1 [Mitcho]
> * Double checking for memory leaks. [Ehsan]
>
> All in all, things are looking in fantastic shape. Everybody is sacrificing to get Tab Candy onto trunk, but if the media hype is to be believed, we are all about to change the face of web browsing. Super-awesome-excellent work everyone. I think with just one more major push we'll be in beta 4. Next stop, nearly half-a-billion people and the world!
>
> -- aza | ɐzɐ --
>

Aza

unread,
Aug 11, 2010, 3:02:23 AM8/11/10
to Mike Beltzner, dev-apps-firefox, Paul O’Shannessy, Ehsan Akhgari, Edward Lee, Gavin Sharp, Mayumi Matsuno, L. David Baron, Johnathan Nightingale, Dão Gottwald, Juan Becerra, Tracy Demiroz, Atul Varma, mitcho (Michael 芳貴 Erlewine), Ian Gilman, Raymond Lee, Justin Dolske
Hey all,

Beltzner has a great tl;dr version:

We are close to being able to land, and need to make sure we can get review
on the four patches below in time for Mitcho and Ehsan to address any
comments that come up. Dao, Dolske and Paul: if you don't think you can get
those reviews in time, please let us know ASAP and maybe suggest an
alternate reviewer?

-- aza | ɐzɐ --

On Tue, Aug 10, 2010 at 11:41 PM, Aza <a...@mozilla.com> wrote:

> == Aug 10 2010 ==
>
> Current Goal: Land on trunk by Wed night.
>
> Things are looking up for Tab Candy to land in beta 4. The addition of
> Ehsan to the team (thanks to Roc's blessings) have really pushed things
> forward especially in Ts. Mitcho has done a great job of fixing review
> comments as they come up, Ian Gilman has got our architecture humming,
> Mardak is spinning patches with deft fingers, and Raymond Lee is making our
> unit tests robust.
>
> Unfortunately, Mitcho and Ehsan are unavailable on Thursday meaning that
> most of the work has to be done by Wednesday evening. Our goal is to land by
> then. Landing Friday is out of the question as we need to let this major new
> feature have time to bake.
>
> The overview of what we need to do is:
>
> 1. Be within a 2% Ts regression, with a plan how to reduce that number to
> 0.
> Ehsan did some heroics here to accomplish this feat.

> https://bugzilla.mozilla.org/show_bug.cgi?id=583388 *[DONE!]*


> 2. Have tests for the modifications that we've made to the browser code.

> https://bugzilla.mozilla.org/show_bug.cgi?id=577321 *[Raymond: ON
> TRACK]*
> 3. Have reviews on the patches.* [HIGHEST RISK: See below]*
>
> *== Needing Review ==*


>
> * Land Tab Candy Utility Code (iq.js)
> We've gone through a round of reviews with Gavin and then Dao. We appear
> to be in the nitpick stage. We need final approval ASAP.

> https://bugzilla.mozilla.org/show_bug.cgi?id=582023 *[Needs Dao's r+]*


> * Provide a way to show certain tabs and get visible tabs.
> Gavin also did a round of reviews but asked Dao to weigh in. We also
> appear to be in the nitpick stage. Need final approval ASAP.

> https://bugzilla.mozilla.org/show_bug.cgi?id=582116 *[Needs Dao's r+]*


> * Restore visible tabs (and hide hidden ones)
> Mardak has put up a very small patch with unit tests. Waiting for Paul.

> https://bugzilla.mozilla.org/show_bug.cgi?id=586147 *[Needs Zpao's r+]*


> * Review the Tab Candy core (Land Tab Candy on Trunk)
> Dolske has been doing an heroic job of reviewing our code. He's got
> "just" the self-
> contained bits in browser/base/content/tabview left to do. He's
> optimistic it can
> be done.

> https://bugzilla.mozilla.org/show_bug.cgi?id=574217 *[Needs Dolske's r+]
> *
>
> *== Blocking Bugs ==*


>
> * Title and Tab Bars or the Menu and Tab Bars to appear solid black with
> Tab Candy
> Atul reports that removing the iframe dynamically via DOMi removes the
> black, as does adding "display:none".

> https://bugzilla.mozilla.org/show_bug.cgi?id=581813 *[Iangilman]*


> * Interpolation out-of-range assertion for Tab Candy Style Animation
> Dbaron is currently trying to land his patch:

> https://bugzilla.mozilla.org/show_bug.cgi?id=575672 *[Dbaron]*
>
> *== Unit Tests ==*


>
> * Test tab previews in presence of Tab Candy

> https://bugzilla.mozilla.org/show_bug.cgi?id=585854 *[Raymond]*
>
> *== Things to Keep An Eye On ==*


>
> * We are currently have some issues around the bookmarks all tab command.
> Not enough to block, but something to keep an eye on.

> https://bugzilla.mozilla.org/show_bug.cgi?id=585855#c1 *[Mitcho]*
> * Double checking for memory leaks. *[Ehsan]*

Aza

unread,
Aug 11, 2010, 2:41:21 AM8/11/10
to Mike Beltzner, dev-apps-firefox, Paul O’Shannessy, Ehsan Akhgari, Edward Lee, Gavin Sharp, Mayumi Matsuno, L. David Baron, Johnathan Nightingale, Dão Gottwald, Juan Becerra, Tracy Demiroz, Atul Varma, mitcho (Michael 芳貴 Erlewine), Ian Gilman, Raymond Lee, Justin Dolske
== Aug 10 2010 ==

Current Goal: Land on trunk by Wed night.

Things are looking up for Tab Candy to land in beta 4. The addition of Ehsan
to the team (thanks to Roc's blessings) have really pushed things forward
especially in Ts. Mitcho has done a great job of fixing review comments as
they come up, Ian Gilman has got our architecture humming, Mardak is
spinning patches with deft fingers, and Raymond Lee is making our unit tests
robust.

Unfortunately, Mitcho and Ehsan are unavailable on Thursday meaning that
most of the work has to be done by Wednesday evening. Our goal is to land by
then. Landing Friday is out of the question as we need to let this major new
feature have time to bake.

The overview of what we need to do is:

1. Be within a 2% Ts regression, with a plan how to reduce that number to 0.
Ehsan did some heroics here to accomplish this feat.
https://bugzilla.mozilla.org/show_bug.cgi?id=583388 *[DONE!]*
2. Have tests for the modifications that we've made to the browser code.
https://bugzilla.mozilla.org/show_bug.cgi?id=577321 *[Raymond: ON TRACK]*

3. Have reviews on the patches. We need Dao's help here.* [HIGHEST RISK: See
below]*

*== Needing Review ==*

Our biggest risk is that we won't get the reviews back from *Dao* in time.

Shawn Wilsher

unread,
Aug 11, 2010, 4:20:26 PM8/11/10
to dev-apps...@lists.mozilla.org
On 8/11/2010 12:02 AM, Aza wrote:
> We are close to being able to land, and need to make sure we can get review
> on the four patches below in time for Mitcho and Ehsan to address any
> comments that come up. Dao, Dolske and Paul: if you don't think you can get
> those reviews in time, please let us know ASAP and maybe suggest an
> alternate reviewer?
What about sr for all the new APIs that are being added for this?

Cheers,

Shawn

Mike Shaver

unread,
Aug 11, 2010, 4:22:49 PM8/11/10
to Shawn Wilsher, dev-apps...@lists.mozilla.org
On Wed, Aug 11, 2010 at 4:20 PM, Shawn Wilsher <sdw...@mozilla.com> wrote:
> What about sr for all the new APIs that are being added for this?

They'll get sr as needed; vlad just did one for the iq stuff.

Mike

Reply all
Reply to author
Forward
0 new messages