Re: [desktop][feature] Form Autofill Credit Card +Sync - pre-beta sign-off RED

[Matthew Noorenberghe]

On Wed, Sep 27, 2017 at 2:06 PM, Ritu Kothari <rkot...@mozilla.com> wrote:

On Wed, Sep 27, 2017 at 1:12 PM, Matthew Noorenberghe <mnoore...@mozilla.com> wrote:

Hi Ritu,

On Wed, Sep 27, 2017 at 11:27 AM, Ritu Kothari <rkot...@mozilla.com> wrote:

Hi MattN, Vance,

Could you elaborate a bit more on the post-57 bit?

​We aren't targeting a specific​ version for the credit card portion, we'll ship it when it's ready. We'll let you know when we have a better idea of when that is. We're not adding scope, just improving quality, especially heuristics.

Thanks Matt. Got it. I think the trello card "Form autofill MVP (credit card support)" might need to be moved to 58 or backlog.

​True, moved.​

 

 

Has the "credit card + Sync" bits been disabled in Beta57 as well? Or will it continue to ride Beta57 cycle but will not be turned on in release 57?

​Yes, it was disabled before the first 57 beta in bug 1399382. We don't want it to interfere with testing of Quantum/Photon since there's no intention to ship in 57 anymore.​

Perfect.

I am told most of form autofill happens via a system add-on which makes the "disabling" piece interesting. Are there different versions of this SAO in mozilla-central vs mozilla-beta and is that how we have removed it from 57 scope?

​The system add-on is developed in mozilla-central so it does naturally ride the trains by default. Address and credit card autofill are in one SAO but there is a pref check inside the SAO to disable credit card support. ​extensions.formautofill.creditCards.available is the relevant pref btw.

Yes, I see that pref is set to false on my 57.0b3 client. I see another pref "...formautofill.creditCards.enabled" set to true. I am assuming that is intentional.

​Yes, that's correct. .available controls whether the feature is available to users, .enabled is for the user-visible control in about:preferences#privacy if the user unchecks the feature because they don't want it.​ i.e. .enabled has no effect if .available is false.

 

Thanks,

Ritu

 

Thanks,

Ritu

On Fri, Sep 15, 2017 at 9:08 AM, Vance Chen <vc...@mozilla.com> wrote:

Hi Gabriela,

After discussing with PM team, we decide to move the credit card autofill part to post-57 in order to do more comprehensive testing and also to gather more users feedback.

Thanks.

Vance

On Fri, Sep 15, 2017 at 11:12 PM, Gabriela Cheta <gas...@softvision.ro> wrote:

Form Autofill MVP (credit card support) +SYNC

Feature sign off report, Manual QA

Targeted GA: Firefox 57 - September 19, 2017

Sign off phase: pre-beta(Fx57)

 

MANUAL QA’S ASSESSMENT & RECOMMENDATION

Feature status: RED

• Reasons:

• Credit Card Sync not implemented: Bug 1395028
• Autofill is not working for some top shopping sites (Bug 1398101) ,managed to do a quick spot check on a try build and autofill is not working properly for some sites:groupon.com, newegg.com - have autofill issues that need to be investigated
• We need more time for testing to make sure the fix for the above bugs did not cause regressions
  

Recommendation: DON'T SHIP IT

• Reason: Autofill is not working for some top shopping sites (Bug 1398101)
  

• Proposed course of action:
  

  • @Gabi further testing is needed on main shopping sites

  • @Gabi will verify the remaining bugs and focus on credit card sync
  • Devs to fix the above mentioned issues
  • release-drivers to take a final decision about letting this feature go to beta

 

MANUAL TESTING SUMMARY

Testing status: COMPLETED (100%).

• Test report: onTestRail

• New bugs uncovered during sign off: Bug 1399065, Bug 1399402

• Known bugs encountered during sign off: Bug 1398101, Bug 1392528 ,Bug 1395028

• Notes: We managed to conduct testing on Latest Nightly under Windows 7 x64, Windows 10 x64, Ubuntu 14.04 x64 and Mac OS X 10.12.
  

FEATURE HEALTH TREND

• First sign off

OWNERSHIP & BASIC INFORMATION

• Test plan: TestRail

• QA contact(s): Gabi Cheta, Bogdan Maris (peer).

• Engineering contact(s):Vance Chen, Matthew Noorenberghe, Luke Chang, Steve Chung, Sean Lee, Scott Wu, Ray Lin, John Dai, Juwei Huang

 Please let me know if you have any feedback or questions about this report.

Thanks,

Gabi Cheta QC Engineer Softvision The content of this communication is classified as Softvision Confidential and Proprietary Information.

[Ritu Kothari]

On Wed, Sep 27, 2017 at 1:12 PM, Matthew Noorenberghe <mnoore...@mozilla.com> wrote:

Hi Ritu,

On Wed, Sep 27, 2017 at 11:27 AM, Ritu Kothari <rkot...@mozilla.com> wrote:

Hi MattN, Vance,

Could you elaborate a bit more on the post-57 bit?

​We aren't targeting a specific​ version for the credit card portion, we'll ship it when it's ready. We'll let you know when we have a better idea of when that is. We're not adding scope, just improving quality, especially heuristics.

Thanks Matt. Got it. I think the trello card "Form autofill MVP (credit card support)" might need to be moved to 58 or backlog.

 

Has the "credit card + Sync" bits been disabled in Beta57 as well? Or will it continue to ride Beta57 cycle but will not be turned on in release 57?

​Yes, it was disabled before the first 57 beta in bug 1399382. We don't want it to interfere with testing of Quantum/Photon since there's no intention to ship in 57 anymore.​

Perfect.

I am told most of form autofill happens via a system add-on which makes the "disabling" piece interesting. Are there different versions of this SAO in mozilla-central vs mozilla-beta and is that how we have removed it from 57 scope?

​The system add-on is developed in mozilla-central so it does naturally ride the trains by default. Address and credit card autofill are in one SAO but there is a pref check inside the SAO to disable credit card support. ​extensions.formautofill.creditCards.available is the relevant pref btw.

Yes, I see that pref is set to false on my 57.0b3 client. I see another pref "...formautofill.creditCards.enabled" set to true. I am assuming that is intentional.