Rhino AST and JSCoverage

116 views
Skip to first unread message

tntim96

unread,
Sep 26, 2011, 6:11:18 PM9/26/11
to mozilla-rhino
I've re-writen a good part of JSCoverage (http://siliconforks.com/
jscoverage/) in Java using Rhino as the parser instead of
Spidermonkey. The AST addition to Rhino is excellent, but I've found a
few small bugs. (The existing JSCoverage test suite is quite good, and
highlights some differences between Rhino and Spidermonkey).

Is anyone, Rhino committer or other, interested in working with me to
resolve the Rhino AST bugs?
Is anyone interested in working on the Java re-write of JSCoverage (no
public repository as yet)?

Bugs to date are:
684131-AstNode missing operator name "^=" (ASSIGN_BITXOR) - patch
included
686822-ArrayComprehensionLoop.toSource missing each keyword - patch
included
687669-Calling toSource on a parsed script omits any empty expression
- sample attached
688018-Calling toSource on a parsed script containing 'void' throws
exception - sample attached
688021-Calling toSource on a parsed script containing debugger omits
semi-colon - sample attached
688023-Calling toSource on a parsed script containing if without
braces not indented - sample attached
689308-Calling toSource on a parsed script containing array of
undefined elements returns smaller array - sample attached

Attila Szegedi

unread,
Sep 26, 2011, 7:37:38 PM9/26/11
to mozill...@googlegroups.com
Hi,

I've committed those for which you had patches to GitHub; I'm afraid that's as far as I can take it right now. I'd encourage you to figure out patches for the rest of them. Actually, if you just fork Rhino on GitHub, fix the issues in your fork, and submit a pull request, we can get them all in easily into mainline.

Thanks,
Attila.

tntim96

unread,
Dec 10, 2012, 3:52:16 AM12/10/12
to mozill...@googlegroups.com
Thanks for fixing those. I've since found a couple of other bugs which I've had to fork to resolve. The fixes are here: https://github.com/mozilla/rhino/pull/99

Also, is there a road map for Rhino? There's quite a few pull requests and there doesn't seem to be much recent commit activity. http://www.ohloh.net/p/rhino
Reply all
Reply to author
Forward
0 new messages