"this" problems when upgrading to Rhino 1.8.0 -

[mich.b...@gmail.com]

Hello everyone,

I recently updated to Rhino 1.8.0 from  1.7.14. First - it's great to see that new versions are coming out, and big thanks to everyone involved.

All in all the update was pretty easy, but the following code breaks at runtime:

        String code = "ns.forEach(e=>javaSet.add(e))";

        try ( Context cx = Context.enter() ) {
            ScriptableObject tlScope = cx.initStandardObjects();
            Set<Object> javaSet = new HashSet<>();
            tlScope.put("ns", tlScope, ns);
            tlScope.put("javaSet", tlScope, javaSet);
            cx.evaluateString(tlScope, code, "", 1, null);

            return new NativeSetStub(javaSet);
        }

Reporting the error: org.mozilla.javascript.EcmaError: TypeError: Method "forEach" called on incompatible object. (#1)

From what I gather, this means that the Set instance ns is not a Set object when the "forEach" method is called, but I may be wrong.

Any ideas?

Thanks,

Michael

[mich.b...@gmail.com]

Deep debugging update: The error is sent from NativeSet::realThis, because the NativeSet instance's instanceOfSet field is set to false. NativeSet.java, line 180.

This might have to do with the set coming from a continuation. Any help is highly appreciated :-)

[mich.b...@gmail.com]

Workaround: serialize with a scope generated by `context.initStandardObjects()`. See https://github.com/mozilla/rhino/issues/1839 for more info.