Review Board UI Modifications

26 views
Skip to first unread message

Steven MacLeod

unread,
Apr 7, 2014, 1:08:34 AM4/7/14
to mozilla-c...@googlegroups.com
Hey everyone,

I threw together a couple UI mockups for modifications to RB we can implement quickly. These are intended to improve navigation for user unfamiliar to RB and are meant to be easily implemented as an extension robust to changes in the review board core.

There are plans to streamline some of the RB navigation and UI in core itself, so in the medium term I think we should work with the team to improve RB, but with the aggressive schedule here we should be able to toss something like the following together quickly.

The main idea is to introduce a tabbed interface along the lines of github's pull request pages, giving a more straightforward way to switch between viewing reviews and diffs. We can also introduce our own tab to display commit data we've provided to RB (this would allow linking out to the actual commits on hg.mozilla.org, and provide an obvious linking to each review request that is part of a push).

I think by keeping the modifications simple with the additions of tabs, and some hiding of elements that aren't needed at Mozilla we can implement this quickly and without forking RB.

Here is a mockup over the page showing reviews (reviews are displayed off bottom of page).

Inline image 1


and here is a mockup of the "Commits" tab:

Inline image 2


I stayed away from commenting on any of the stylistic elements like possible colour scheme modifications - I'm not a designer.

- Steven


Taras Glek

unread,
Apr 7, 2014, 11:34:32 AM4/7/14
to Steven MacLeod, mozilla-c...@googlegroups.com


Sunday, April 6, 2014 22:08
Thanks Stephen.
We should imitate github/bitbucket/etc colors/styles. I'm not a designer, but yellow does not scream modern :)

Taras

- Steven


--
You received this message because you are subscribed to the Google Groups "mozilla-code-review" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mozilla-code-re...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Ehsan Akhgari

unread,
Apr 8, 2014, 1:55:46 PM4/8/14
to Taras Glek, Steven MacLeod, mozilla-c...@googlegroups.com
Do we have a designer which we can get help from here?

Taras Glek

unread,
Apr 8, 2014, 2:06:43 PM4/8/14
to Ehsan Akhgari, Steven MacLeod, mozilla-c...@googlegroups.com
Lets get this mockup implemented. Designers are better once there are users to interview.

Taras



postbox-contact.jpg

Ehsan Akhgari

unread,
Apr 8, 2014, 2:08:14 PM4/8/14
to Taras Glek, Steven MacLeod, mozilla-c...@googlegroups.com
Sounds good!
Reply all
Reply to author
Forward
0 new messages