Issue 59 in pymox: MockObject.__eq__ behaviour causes problems when the mocks are used in lists.

[codesite...@google.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 59 by ruben.la...@gmail.com: MockObject.__eq__ behaviour causes
problems when the mocks are used in lists.
https://code.google.com/p/pymox/issues/detail?id=59

MockObject and MockAnything are just equal to any other mock that happens
to have the same "replay_mode" and "expected_calls_queue". That creates
problem when the mocks are used in sequences / collections / lists. For
example, list.count() will probably give the wrong result as it will count
all mock instances.

Here is an example

import mox

mocker = mox.Mox()
mock1 = mocker.CreateMockAnything(description="mock1 is unique")
mock2 = mocker.CreateMockAnything(description="mock2 is also unique")
print [mock1, mock2].count(mock1) #=> 2 but should be 1


Wouldn't be better if __eq__ compared at least the attrs of the mocks? If
they have a different set of mocked attributes they can't be "equal", right?


--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings