Fwd: [motech] push by alexnavi...@gmail.com - Alex, Isha | 767 | End date should be at the end of the day for job sc... on 2012-02-10 07:10 GMT

7 views
Skip to first unread message

Bruce MacLeod

unread,
Feb 10, 2012, 7:19:16 AM2/10/12
to motech-ar...@googlegroups.com
Has there been agreement or discussion on the unit of timing for schedule tracking and message campaigns ? We have refactored code to support minute and hour granularity for messaging in our messagecampaign-demo branch and we are attempting to keep it aligned with the current code base.

The commit below suggest that days continue to be the unit of time for schedule tracking. Do I have this wrong or am I misunderstanding something ?

-------- Original Message --------
Subject: [motech] push by alexnavi...@gmail.com - Alex, Isha | 767 | End date should be at the end of the day for job sc... on 2012-02-10 07:10 GMT
Date: Fri, 10 Feb 2012 07:11:03 +0000
From: mot...@googlecode.com
Reply-To: motec...@googlegroups.com
To: motec...@googlegroups.com


Revision: 343e98460d39
Author:   Alex Anto Navis L <ale...@thoughtworks.com>
Date:     Fri Jun 13 09:02:53 2014
Log:      Alex, Isha | 767 | End date should be at the end of the day for  
job scheduled for the message.

http://code.google.com/p/motech/source/detail?r=343e98460d39

Modified:
  
/motech-message-campaign/src/main/java/org/motechproject/server/messagecampaign/scheduler/RepeatingProgramScheduler.java
  
/motech-message-campaign/src/test/java/org/motechproject/server/messagecampaign/scheduler/RepeatingProgramSchedulerTest.java

-- 
You received this message because you are subscribed to the Google Groups "MoTeCH Developer" group.
To post to this group, send email to motec...@googlegroups.com.
To unsubscribe from this group, send email to motech-dev+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/motech-dev?hl=en.

Sanchit Bahal

unread,
Feb 11, 2012, 9:49:38 AM2/11/12
to motech-ar...@googlegroups.com

Hi Bruce,

 

The intention of the below commit was just to ensure that the end date of the message campaign is set properly, i.e., the time component for the end date should be 23:59:59 hours.

 

The current implementations of Schedule Tracking and Message Campaign modules support only days and weeks as the unit of time. And I am not aware of any discussion in this regard.

However, I got a similar request from the recently started Drishti project. They wanted Schedule Tracking and Message Campaign to support minute and hour granularity for testing purposes.

 

Thanks,

Sanchit Bahal

Mobile: +91 9980141983

Reply all
Reply to author
Forward
0 new messages