Bug in Wavelength.py

[stiny...@g.hmc.edu]

Hello Nick,

In the for loop from line 717 to line 745, the variable "coeffs" is never defined if the first if condition (line 719) is not satisfied. This causes an error when "coeffs" is called at line 747.

Best,
Kaew

[Nick Konidaris]

This is an interesting catch. 

The bug you found implies that the wavelength solution failed on the first pixel in the slit. I've never seen such a failure before, can you tell me what happened in your date such that this bug appeared?

The issue number is 64, I'll correct it in a future release.

~n

--
You received this message because you are subscribed to the Google Groups "MOSFIRE Data Reduction PIpeline" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mosfire-drp...@googlegroups.com.
To post to this group, send email to mosfi...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mosfire-drp/b9d7a3b3-a786-4a97-930c-1b2b8675d385%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
   +1 831 704 6425

[Kaew Tinyanont]

I'm not entirely sure since other frames from the same night work fine. The most likely cause is that the last slit's edge extends to the very bottom of the frame but the skylines stop short of that (at around pixel 120.) So I got large RMS error in pixel 1-120 during the "apply_lambda" stage.

By the way, is there a way to manually specify slit edges?

Best,
Kaew

--
You received this message because you are subscribed to a topic in the Google Groups "MOSFIRE Data Reduction PIpeline" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mosfire-drp/O5xtRcyXtxk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to mosfire-drp...@googlegroups.com.

To post to this group, send email to mosfi...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/mosfire-drp/CACYwDF51_6dFgzYbZ7GzFK8c5558tEAJcqKDmRZ2wLoMF19LRA%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--
(Kaew) Samaporn Tinyanont

HMC '15

[hanae...@gmail.com]

Hi Kaew, Nick,

I actually also encounterd the same issue. It seems that it happened at Slit 1 -- I modified the "for i" loop in the "apply_lambda_sky_and_arc" funtion to skip the first slit, and it ran through without any problems. And yes, as Kaew's, I got larger RMS errors (> 0.5) for S01 (@ p7 to p18) compared with the other slits when I ran "Wavelength.fit_lambda". The others are almost all around ~0.1.

Hanae



2014年6月16日月曜日 14時03分49秒 UTC-7 Kaew Tinyanont:

[Nick Konidaris]

Thanks,

Can you send me the wavelength data that the pipeline is trying to fit?

N

To view this discussion on the web visit https://groups.google.com/d/msgid/mosfire-drp/a62aa194-e6bf-4694-957d-e6c16bf3796c%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
Sent from Gmail Mobile