Issue 95 in mortar: Create a factory method for calling locations

0 views
Skip to first unread message

mor...@googlecode.com

unread,
Apr 9, 2010, 1:24:34 AM4/9/10
to mortar...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Enhancement Priority-High

New issue 95 by charlequin: Create a factory method for calling locations
http://code.google.com/p/mortar/issues/detail?id=95

(1:15:18 AM) tedivm: we used to store the internals as an id and i switched
away from that because we
ended up rebuilding the location class quite a bit
(1:15:42 AM) charlequin: the difficulty I see is basically as follows: if
you never know how long the
location is going to sit around storing a whole copy of its parent in
memory, you don't know whether
any of the location-specific info has changed since you generated it
(1:16:43 AM) charlequin: and I'm guessing that if I have to poll the
database to check the last
timestamp when the location was changed, I've already taken a performance
hit, yes?
(1:17:09 AM) tedivm: Solution- create a factory method for calling
locations and funnel all "new
Location()" calls through it, then when can have it cache our location
creation
(1:17:18 AM) tedivm: i bet that would save us a ton of resources
(1:17:48 AM) charlequin: now that does seem like an excellent idea
(1:17:50 AM) tedivm: and it would let us use dependency injection
techniques to change the location
system later down the line without fucking with the developers too much
(1:17:59 AM) charlequin: especially since we instantiate Locations all the
fucking time
(1:18:06 AM) tedivm: yeah, we really fucking do
(1:18:13 AM) tedivm: more caching for the win!

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

mor...@googlecode.com

unread,
May 9, 2010, 7:55:52 PM5/9/10
to mortar...@googlegroups.com
Updates:
Status: Fixed

Comment #1 on issue 95 by charlequin: Create a factory method for calling
locations
http://code.google.com/p/mortar/issues/detail?id=95

This issue was closed by revision r1694.

--
You received this message because you are subscribed to the Google Groups "Mortar Issues" group.
To post to this group, send email to mortar...@googlegroups.com.
To unsubscribe from this group, send email to mortar-issue...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/mortar-issues?hl=en.

Reply all
Reply to author
Forward
0 new messages