Issues with the newest Version (from Dec 2010)

[frozeman]

hi,

while adding the new moorte, i get some erros in firebug:

the first is this, it happens sometimes, when i relaod the page

uncaught exception: [Exception... "Component returned failure
code: 0x80004005 (NS_ERROR_FAILURE)
[nsIDOMNSHTMLDocument.execCommand]" nsresult: "0x80004005
(NS_ERROR_FAILURE)"
location: "JS frame :: http://localhost/_feindura/library/thirdparty/MooRTE/Source/moorte.js
:: anonymous ::
line 236" data: no]

the second is when i select a text:
shorts.has is not a function
if(e && e.control && shorts.has(e.key))
moorte.js (Zeile 246)


any ideas?
fabian

[SamGoody]

Have tried refreshing quite a few times, and cannot reproduce the bug.
(My copy of your CMS is up to date, I pulled all your requests this
morning in order to see if I can spot the bug)

Could you tell me what steps you've taken, or somehow point me to a
page where this happens?

I have a vague memory that this is a FF bug related to pressing enter
within an editable span, and that I had a neat solution...
Help me rout this.

Thanks

PS: I will be traveling a bit so responses for the next week may be
delayed..

[Fabian [frozeman.de]]

i just copied the newest version of moorte in my cms and go to the frontendediting mode and klick in a page to edit it and then show the:

shorts.has is not a function
    moorte.js (Zeile 246)

error up. there is nothin special what i did.
what is short and why it couldnt have this function?

fabian

[frozeman]

the error appears when selecting text

[frozeman]

i found the problem!

http://mootools.net/docs/core/Types/Object#Deprecated-Functions:Hash:has

has is deprecated, and it works for you, cause you have the Hash in
your mootools ore included, i think.

you can use:
myObject.myKey != undefined

[frozeman]

so infact:

shorts[e.key] != undefined

works for me

[frozeman]

another issue, i found, when i press the save button:


washer.hasChild is not a function
if(washer.hasChild(washer.retrieve('bar')))
washer.moorte('remove');
moorte.js (Zeile 475)
any ideas?

[frozeman]

and sometimes i get this erro:

[frozeman]

sorry for the massiv error reports here. but they are mostly the same
one:

i think the problem with the save button is cause you use still some
moo 1.2 globals, like $H in line 595

var content = $H({ 'page': window.location.pathname }), next = 0;
content.content=[];

in feindura i overwrite the save function with my own with
"Object.extend(MooRTE.Elements, ...);" but i get this washer error,
reportet above.

it seems the he dowsnt overwrite your save function?


fabian

[SamGoody]

Will be looking into this now.

Delay due to a thirteen hour flight (with an infant on my lap), long
weekend, and not having your setup on my laptop yet.

On all tests I did last week I could not get any errors, so I may need
more help trying to find this bug.

Will post again if I find any errs after setting up on my laptop.

Sam Goody

[SamGoody]

I have no idea which version of MooRTE you are using, but it must be
really old.

Take a look at the develop branch, anytime in the past month:
https://github.com/siteroller/moorte/blob/develop/Source/moorte.js

As you can see, the $H has long been vetted.

StickyWin needs MooTools 1.2 compatibiliy, and you use that in your
popups, but it is not at all required for mooRTE to work.

Please download the latest version from the develop branch, and see if
you still have issues.

Also

I have tried downloading Feindura from https://github.com/frozeman/feindura-flat-file-cms.
It complains that the config files are absent, which they are.

I am glad the config files are no longer being tracked, the old method
was really not good.
But you must give PHP the ability to create them dynamically, or there
is no way to use your CMS.

As soon as you have it setup, I will be happy to try to debug. Till
then I've given up.

Sam

On Jan 8, 2:37 pm, frozeman <fab...@frozeman.de> wrote:

[Fabian]

Hm youre right, but the configs will be created when you save settings.

But I will change that.

I used the newest moorte version. Maybe something went wrong?

What ist the difference between the source folder and the specs folder?

Bit the has function is still present in the newest version?

I will fix it when feindura when I have time.

Fabian

Von meinem iPhone gesendet

[Fabian [frozeman.de]]

i didnt ha d time to work futhur, but i looked at the

https://github.com/siteroller/moorte/blob/develop/Source/moorte.js

and the $H is still there: line 595

and the .has is also still there, which is not in the core of mootools anymore only in the "hash" of more, but you can replace it with:
shorts[e.key] != undefined

in line 246, like i wrote it above.

i hab also a few questions you didnt answer:

• in feindura i overwrite the save function with my own with
  "Object.extend(MooRTE.Elements, ...);" but i get this washer error,
  reportet above.
  it seems the he dowsnt overwrite your save function?

• how can i add or remove an instance in moorte? 
  i would like to disable and enable the frontend editing in feindura 
  cms, so i have to remove the moorte editing and add it again, if 
  possible...
  

could ou answer these?

thanks in before
fabian

[SamGoody]

Hi Fabian,

Just got back home after quite an exhausting excursion into the frigid
winters of New York.
Despite a bit of backlog I will try to answer properly tomorrow.

Off the cuff though:

> and the $H is still there: line 595

That didn't affect you, as you have your own save button which
overrides this one.
Nonetheless, it needed to be fixed. Done. Thanks for pointing it out.

> and the .has is also still there

Hmm, I left it there thinking 'shorts' was an array. Should look into
it tomorrow.

> i get this washer error, reported above.
It works for me. The old save is correctly overridden by your new save
button.
See if your code looks like mine (~line 320), as you may be being
caught on a typo:
https://github.com/SamGoody/feindura-flat-file-cms/blob/moorte/library/javascripts/frontendEditing.js

> how can i add or remove an instance in moorte?

You correctly made that its own thread.
I thought it was well documented and therefore waited till I had time
to see if there was something big up.

Will try to check that out as well on the morrow.

Sam

On Jan 12, 1:14 pm, "Fabian [frozeman.de]" <fab...@frozeman.de> wrote:
> i didnt ha d time to work futhur, but i looked at the
>
> https://github.com/siteroller/moorte/blob/develop/Source/moorte.js
>
> and the $H is still there: line 595
>
> and the .has is also still there, which is not in the core of mootools anymore only in the "hash" of more, but you can replace it with:
> shorts[e.key] != undefined
>
> in line 246, like i wrote it above.
>
> i hab also a few questions you didnt answer:
>

>     *

>
>       in feindura i overwrite the save function with my own with
>       "Object.extend(MooRTE.Elements, ...);" but i get this washer error,
>       reportet above.
>       it seems the he dowsnt overwrite your save function?
>

>     * how can i add or remove an instance in moorte?

[SamGoody]

> What ist the difference between the source folder and the specs folder?

The specs folder no longer exists :)
The file that was there is now renamed to moorte.documented, and is a
documented but outdated version of moorte.

The spec folder was meant to be used for Jasmine / Spec runner or even
just jslinting.
Unfortunately I have no idea how to use Jasmine, and jslint wont
accept our haskell style conventions.

Any help here by someone who has experience with Jasmine/JSSpec/
Selenium/jUnit or any such framework, would be much appreciated.

Ditto help by anyone who can configure jslint or its forks to use our
non-crockford conventions.

> and the .has is also still there

Good catch. Thanks.
While fixing that I noticed that there was a few function.run() calls
as well.
Fixed. Much appreciated.

If you see such errs in the future, feel free to create a pull request
so you can get the credit.

1. Click "fork" on my project
2. clone the fork to your local machine
3. fix the issue. commit and push.
4. send me a pull request.

Notice that I have recently pulled Anthony's code.
I am happy to pull from those who chip in!

See here:
http://help.github.com/pull-requests/
https://github.com/blog/712-pull-requests-2-0

Sam

On Jan 17, 2:28 pm, SamGoody <siterol...@gmail.com> wrote:
> Hi Fabian,
>
> Just got back home after quite an exhausting excursion into the frigid
> winters of New York.
> Despite a bit of backlog I will try to answer properly tomorrow.
>
> Off the cuff though:> and the $H is still there: line 595
>
> That didn't affect you, as you have your own save button which
> overrides this one.
> Nonetheless, it needed to be fixed. Done. Thanks for pointing it out.
>
> > and the .has is also still there
>
> Hmm, I left it there thinking 'shorts' was an array. Should look into
> it tomorrow.
>
> > i get this washer error, reported above.
>
> It works for me. The old save is correctly overridden by your new save
> button.
> See if your code looks like mine (~line 320), as you may be being

> caught on a typo:https://github.com/SamGoody/feindura-flat-file-cms/blob/moorte/librar...

[SamGoody]

The pull from Anthony is supposed to fix the 0x8004005 errors.

See here, though I might move this into its own issue:
https://github.com/siteroller/moorte/issues/#issue/2

> See here:http://help.github.com/pull-requests/https://github.com/blog/712-pull-requests-2-0

[frozeman]

i found another bug:

line 482
washer.hasChild is dprecated use .contains()

i fixed it, and then when i press the save button, he uses your save
function and my one, which should overwrite yours??

fabian

> > See here:http://help.github.com/pull-requests/https://github.com/blog/712-pull...

[frozeman]

ok i solved it with Object.merge instead of Object.extend

fabian

On 21 Jan., 12:01, SamGoody <siterol...@gmail.com> wrote:

> > See here:http://help.github.com/pull-requests/https://github.com/blog/712-pull...

[SamGoody]

Good call, thanks. Will fix.

Sam