Deprecation warnings in OAuth.php sent out with xml

[John Hsu]

Hi, just a heads up on an possible issue:

split() was deprecated in php 5.3, so I'm getting these two warnings
included in the HTTP response before the LTI xml:
"Deprecated: Function split() is deprecated in /usr/share/moodle/mod/
basiclti/OAuth.php on line 755
Deprecated: Function split() is deprecated in /usr/share/moodle/mod/
basiclti/OAuth.php on line 759"

The fix is just replacing the split() calls with explode().

I'm quite confused as to why the deprecation warnings show up. The
warnings aren't present if the LTI consumer and producer are on the
same server, but if I have consumer and producer each on different
servers, they show up.

[Nikolas Galanis]

Fixed it.

Keep in mind that the OAuth we are using currently is just a placeholder as it ignores too many of the official OAuth specifications. We are amidst negotiations with the Moodle people for implementing a more official OAuth library in Moodle. Untill that happens, we will be using the existent OAuth.php

Regards,

Nikolas