Bug?

5 views
Skip to first unread message

mlitzkow

unread,
Oct 19, 2010, 11:26:08 AM10/19/10
to Moodle-BLTI
I think there is an error in "view.php". It seems that

print "window.open('launch.php?id=".$basiclti->id."','window
name');";

Should be:

print "window.open('launch.php?a=".$basiclti->id."','window
name');";

It looks to me like "launch.php" uses the 'a' parameter for a basiclti
id lookup, whereas the 'id' parameter would be used for a course
module id (cmid).

I'm not sure where I should file a bug report, but will do it
properly, if somebody will point me in the right direction.

Nikolas Galanis

unread,
Oct 19, 2010, 11:46:00 AM10/19/10
to moodl...@googlegroups.com
Yeah, it seems you are absolutely right.

Changing it to:

print "window.open('launch.php?id=".$cm->id."','window name');";

should also do the trick, right?

Unfortunately I cannot test it right now since I had to reformat my Mac last week and I have yet to setup a working BasicLTI environment.

Nikolas

Ludo (Marc Alier)

unread,
Oct 19, 2010, 12:07:01 PM10/19/10
to moodl...@googlegroups.com
then do it asap :-D
------
Marc Alier (Ludo)    -   Phd. Collaborating lecturer. UPC - Barcelona Tech.
http://www.essi.upc.edu/~ludo  http://twitter.com/granludo
http://mossegalapoma.cat

mlitzkow

unread,
Oct 20, 2010, 11:47:23 AM10/20/10
to Moodle-BLTI
Yes, that works equally well.

-- mike

On Oct 19, 10:46 am, Nikolas Galanis <ngala...@gmail.com> wrote:
> Yeah, it seems you are absolutely right.
>
> Changing it to:
>
> print "window.open('launch.php?id=".$cm->id."','window name');";
>
> should also do the trick, right?
>
> Unfortunately I cannot test it right now since I had to reformat my Mac last
> week and I have yet to setup a working BasicLTI environment.
>
> Nikolas
>

csev

unread,
Oct 20, 2010, 6:10:13 PM10/20/10
to moodl...@googlegroups.com
Yes - You are absolutely right - I think this is my code - so sorry :)

I owe everyone a beer.

/Chuck
Reply all
Reply to author
Forward
0 new messages