Architecture - Thoughts on require implementation

[Tom Ortega II]

I think we already covered this with https://github.com/montagejs/montage/issues/1039 and in the irc channel, but just wanted to make sure.

Isn't it dangerous to assume that there are no other instances of require, exports or module in the global scope? I've already seen how trying to use the Aloha editor by including their require will confuse line 60 of montage.js because require is defined byt exports and module are not. Sadly, the require that is defined is not the one you think you created.

[Kris Kowal]

Yeah. I’m going to fix this. Montage will drop `montageRequire` and `montageApplicationRequire` onto the global for use in the debugger only.

Internally, we should use require.getPackage({name}) to get the require function of any loaded package. I’ll consider injecting an "application" alias into the named package memo so we can use require.getPackage({name: "application"}) instead of window.require, though I think we should just remove all usage of "window.require" outright. We should *never* use a default "require" because eventually the scenario change and working code will break.

Kris Kowal