Pull request feedback

[Samuel García Martínez]

Hi,
I wrote a patch for the issue
https://jira.mongodb.org/browse/SERVER-5477 two weeks ago and i never
got feedback about it. Is there any way to get feedback and know if it
will be merged?

The related pull request: https://github.com/mongodb/mongo/pull/294

Thanks in advance.

[Alberto Lerner]

Samuel,

Thank you for your contribution and sorry for the late feedback.

The router (mongos) and the aggregation framework aspects that concern
it are undergoing a few changes so the code region this patches
touches is a bit dynamic. In particular we're reviewing the
dependencies/interactions between these two modules. We'd prefer to
change code once that revision is complete.

Alberto.

> --
> You received this message because you are subscribed to the Google Groups "mongodb-dev" group.
> To post to this group, send email to mongo...@googlegroups.com.
> To unsubscribe from this group, send email to mongodb-dev...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/mongodb-dev?hl=en.
>

[Alberto Lerner]

Erich,

This list is a good forum to discuss changes, so feel free to use it.

Performance instrumentation, in particular on the level that you
suggested, is something very useful. It is very helpful to know how a
given platform can support performance counters. However, besides
Win32/64, we support a number of other platforms. A feature at this
level should consider how the same functionality could be ported. It's
very helpful that you have a solid implementation for Win32/64 that we
can look at.

One concern about this implementation, though, is upgrade caveats. We
go the extra mile to make these easy and it seems that, even if very
well documented in your README, there are quite some pitfalls here.

Alberto.

On Fri, Sep 14, 2012 at 8:59 PM, e-siedler <erich....@gmail.com> wrote:
>
> I was about to ask the same thing. I've implemented windows performance
> counters.
>
> https://github.com/mongodb/mongo/pull/275
> https://jira.mongodb.org/browse/SERVER-2541
>
> The pull request queue isn't very encouraging.
>
> Best regards.
>
>
> On Thursday, September 13, 2012 6:50:26 PM UTC-3, Samuel García Martínez

> --
> You received this message because you are subscribed to the Google Groups
> "mongodb-dev" group.

> To view this discussion on the web visit
> https://groups.google.com/d/msg/mongodb-dev/-/TE5NdKG1k70J.

[Justin Dearing]

Erich,

I will try to check this out on my systems. Performance counters are something I want to understand in general. Probably better to aqquire that knowledge with MongoDB than SQL Server.

Justin