Debian packages: Waypoint images not displayed

[Christian Vetter]

Hi,

I noticed, that the waypoint images in the client are not displayed
for the Debian packages.

To reproduce:
1. Click Target button
2. Click "+Waypoint"

You have to modifiy:
if ( QFile::exists( QString( ":/images/waypoint%1.png"
).arg( id ) ) )
button->setIcon( QIcon( QString(
":/images/waypoint%1.png" ).arg( id ) ) );

I think for 0.3.1 we should introduce a global setting that specifies
the base image / data path, making it easier to package it. Would a
compile flag be better than having to apply a small patch?

Regards,

Christian Vetter

[David Paleino]

On Fri, 20 May 2011 14:34:36 +0200, Christian Vetter wrote:

> Hi,

Hello :)
no need to CC me, I follow the ML through gmane ;)

> I noticed, that the waypoint images in the client are not displayed
> for the Debian packages.
>
> To reproduce:
> 1. Click Target button
> 2. Click "+Waypoint"

Ok, I never used that feature :)

> You have to modifiy:
> if ( QFile::exists( QString( ":/images/waypoint%1.png"
> ).arg( id ) ) )
> button->setIcon( QIcon( QString(
> ":/images/waypoint%1.png" ).arg( id ) ) );
>
> I think for 0.3.1 we should introduce a global setting that specifies
> the base image / data path, making it easier to package it. Would a
> compile flag be better than having to apply a small patch?

They're the same to me, do as you wish.

While you're at it, I got a bug (http://bugs.debian.org/626671) complaining
about the use of -march=native. Would you like me to keep the patch dropping
it, or would you drop that upstream? :)

Kindly,
David

--
. ''`. Debian developer | http://wiki.debian.org/DavidPaleino
: :' : Linuxer #334216 --|-- http://www.hanskalabs.net/
`. `'` GPG: 1392B174 ----|---- http://deb.li/dapal
`- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[Christian Vetter]

Hi,

On Fri, May 20, 2011 at 7:54 PM, David Paleino <da...@debian.org> wrote:
> Hello :)
> no need to CC me, I follow the ML through gmane ;)

Ok.

> While you're at it, I got a bug (http://bugs.debian.org/626671) complaining
> about the use of -march=native. Would you like me to keep the patch dropping
> it, or would you drop that upstream? :)

We'll drop it

Regards,

Christian Vetter