Want to help with Mojolicious development?

18 views
Skip to first unread message

Sebastian Riedel

unread,
Dec 20, 2011, 7:21:23 AM12/20/11
to mojol...@googlegroups.com
We've started collecting todo and wishlist items in the GitHub issue tracker, feel free to join discussions or pick up a task.

https://github.com/kraih/mojo/issues

--
Sebastian Riedel
http://twitter.com/kraih
http://mojolicio.us


Kartik Thakore

unread,
Dec 20, 2011, 12:43:12 PM12/20/11
to mojol...@googlegroups.com
\o/ Can we also hug you ... a lot?

--
You received this message because you are subscribed to the Google Groups "Mojolicious" group.
To post to this group, send email to mojol...@googlegroups.com.
To unsubscribe from this group, send email to mojolicious...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/mojolicious?hl=en.


Sebastian Riedel

unread,
Dec 20, 2011, 12:44:42 PM12/20/11
to mojol...@googlegroups.com
> \o/ Can we also hug you ... a lot?


Yes, you can! \o/

Ben van Staveren

unread,
Dec 20, 2011, 1:19:31 PM12/20/11
to mojol...@googlegroups.com
So for wishes that are not there yet, create an issue, or can we also express
our wishes in the form of pull requests? :)


On 12/21/2011 12:44 AM, Sebastian Riedel wrote:
>> \o/ Can we also hug you ... a lot?
>
> Yes, you can! \o/
>

--
Ben van Staveren
phone: +62 81 70777529
email: benvans...@gmail.com

Sebastian Riedel

unread,
Dec 20, 2011, 2:43:14 PM12/20/11
to mojol...@googlegroups.com
> So for wishes that are not there yet, create an issue, or can we also express
> our wishes in the form of pull requests? :)


Actually, i don't think anyone likes big pull requests out of the blue.
Best to start with a fruitful discussion, and then claim a task. ;)

Ben van Staveren

unread,
Dec 20, 2011, 3:42:32 PM12/20/11
to mojol...@googlegroups.com
True, good point :) Okay so, discussion wise...

I had this thing with Morbo, I have a directory it needs to watch, but it also
contains a mercurial repository, so it picks up all the .hg/ files as well,
which makes the process of checking files and so on take a very long time. Was
wondering if Morbo can either ignore hidden files, or whether an option can be
added to tell it to ignore certain files. Like, there's --watch, to have an
--ignore as well that you can give a filename glob (or a regex).

Nothing major but would let me do some more fun things with Morbo :)


On 12/21/2011 02:43 AM, Sebastian Riedel wrote:
>> So for wishes that are not there yet, create an issue, or can we also express
>> our wishes in the form of pull requests? :)
>
> Actually, i don't think anyone likes big pull requests out of the blue.
> Best to start with a fruitful discussion, and then claim a task. ;)
>

--

Sebastian Riedel

unread,
Dec 20, 2011, 3:55:45 PM12/20/11
to mojol...@googlegroups.com
> I had this thing with Morbo, I have a directory it needs to watch, but it also
> contains a mercurial repository, so it picks up all the .hg/ files as well,
> which makes the process of checking files and so on take a very long time. Was
> wondering if Morbo can either ignore hidden files, or whether an option can be
> added to tell it to ignore certain files. Like, there's --watch, to have an
> --ignore as well that you can give a filename glob (or a regex).
>
> Nothing major but would let me do some more fun things with Morbo :)

This was actually just a bug, Morbo did already ignore hidden files, now it does the same for hidden directories. ;)

https://github.com/kraih/mojo/commit/ea85cb3e58667d234bc08d93175a8519e8d351e0

Ben van Staveren

unread,
Dec 20, 2011, 5:34:49 PM12/20/11
to mojol...@googlegroups.com
Awesome, that solves one part :D Now, for the ignore option, think it's worth
it? I just want to be lazy and tell Morbo to watch 1 directory and ignore 1
file/folder inside there, instead of passing 10 different watch options ;)
Like I said, not a show stopper by any means but would be kinda cool. I toyed
with it a little bit so I do have a somewhat working implementation of it but
it's uh, yeah, needs a little cleanup. Not going to do that though if there's
no need for the feature :D

--

Sebastian Riedel

unread,
Dec 20, 2011, 5:43:39 PM12/20/11
to mojol...@googlegroups.com
> Awesome, that solves one part :D Now, for the ignore option, think it's worth
> it? I just want to be lazy and tell Morbo to watch 1 directory and ignore 1
> file/folder inside there, instead of passing 10 different watch options ;)
> Like I said, not a show stopper by any means but would be kinda cool. I toyed
> with it a little bit so I do have a somewhat working implementation of it but
> it's uh, yeah, needs a little cleanup. Not going to do that though if there's
> no need for the feature :D


Don't think it's worth it, and if it can't be easily tested, chances of getting new code into Morbo are very small.

Ben van Staveren

unread,
Dec 20, 2011, 5:58:37 PM12/20/11
to mojol...@googlegroups.com
Hmm, could be tested by creating the file that's supposed to be ignored and
seeing if it was in fact ignored, but I guess in the long run it's not worth
it that much.

--

Reply all
Reply to author
Forward
0 new messages