[VOTE] Release Build Helper Maven Plugin 3.1.0

[Stefan Seifert]

Hi,

I'd like to release version 3.1.0 of the Build Helper Maven Plugin

This plugin contains various small independent goals to assist with the Maven build lifecycle.

We solved 7 issues:
https://github.com/mojohaus/build-helper-maven-plugin/issues?q=is%3Aissue+milestone%3A3.1.0+is%3Aclosed

There are still a couple of issues left in GitHub:
https://github.com/mojohaus/build-helper-maven-plugin/issues

Staging Repositories:
https://oss.sonatype.org/content/repositories/orgcodehausmojo-1163

(Staging) Site:
https://www.mojohaus.org/build-helper-maven-plugin/

Diff: https://github.com/mojohaus/build-helper-maven-plugin/compare/build-helper-maven-plugin-3.0.0...build-helper-maven-plugin-3.1.0


[ ] +1
[ ] +0
[ ] -1

The vote is open for 72 hours and will succeed by lazy consensus.

Regards / Cheers /

stefan

[Anders Hammar]

Hi Stefan,

I noticed that the release looks different in Github [1] than before (and in our other mojos). Although it looks nicer and a link to the changelog is probably great for the users, I can't see any change to the release process [2]. Does this happen automagically?

Also, if we want this it should probably be added to the mojoHaus docs [3] and implemented in all mojos.

My apologies if it sounds hard, but I personally think there is little benefit in having differences in our mojos as it makes it more difficult for cross-development and also confuses end users. Improvements are good, but should be done across the board.

[1] https://github.com/mojohaus/build-helper-maven-plugin/releases

[2] https://github.com/mojohaus/build-helper-maven-plugin/blob/master/README.md

[3] http://www.mojohaus.org/development/performing-a-release.html

/Anders

--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/9509b0e7d66c402faebf6d584dcc77e5%40mailx01.intern.pro-vision.de.

[Stefan Seifert]

hello anders.

i've added the link to the changelog (github milestone) manually in the github GUI. this unfortunately does not happen automatic.
i can remove it if you prefer (but i was not sure how users can then easily detect the changes in this release, as there is not changes.xml for this plugin).

how are changelogs maintained for the other mojos?

stefan

>-----Original Message-----
>From: mojoha...@googlegroups.com <mojoha...@googlegroups.com> On
>Behalf Of Anders Hammar
>Sent: Tuesday, March 3, 2020 7:49 PM
>To: mojoha...@googlegroups.com
>Subject: Re: [VOTE] Release Build Helper Maven Plugin 3.1.0
>
>Hi Stefan,
>
>I noticed that the release looks different in Github [1] than before (and
>in our other mojos). Although it looks nicer and a link to the changelog is
>probably great for the users, I can't see any change to the release process
>[2]. Does this happen automagically?
>Also, if we want this it should probably be added to the mojoHaus docs [3]
>and implemented in all mojos.
>
>My apologies if it sounds hard, but I personally think there is little
>benefit in having differences in our mojos as it makes it more difficult
>for cross-development and also confuses end users. Improvements are good,
>but should be done across the board.
>
>[1] https://github.com/mojohaus/build-helper-maven-plugin/releases
>[2] https://github.com/mojohaus/build-helper-maven-
>plugin/blob/master/README.md
>[3] http://www.mojohaus.org/development/performing-a-release.html
>
>/Anders
>

>On Tue, Mar 3, 2020 at 4:25 PM Stefan Seifert <mailto:sseifert@pro-

>email to mailto:mojohaus-dev%2Bunsu...@googlegroups.com.

>To view this discussion on the web visit
>https://groups.google.com/d/msgid/mojohaus-
>dev/9509b0e7d66c402faebf6d584dcc77e5%40mailx01.intern.pro-vision.de.

>--
>You received this message because you are subscribed to the Google Groups
>"mojohaus-dev" group.
>To unsubscribe from this group and stop receiving emails from it, send an

>email to mailto:mojohaus-dev...@googlegroups.com.

>To view this discussion on the web visit

>https://groups.google.com/d/msgid/mojohaus-dev/CAKDUN1vGL1qNjo5QTRoUuc-
>zH8yyo7qoy3JV53D2t-
>zwE38UxA%40mail.gmail.com?utm_medium=email&utm_source=footer.

[Anders Hammar]

There is a changelog in the generated mojo site:

https://www.mojohaus.org/build-helper-maven-plugin/github-report.html

But I'm not saying that the release drafter (is that what it's called) is bad, I'm just saying that it should be documented in the release process.

/Anders

To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/352af0e82c0341d98fb40e684b5a32d8%40mailx01.intern.pro-vision.de.

[Stefan Seifert]

ok, i've created a separate discussion for this question
https://groups.google.com/d/msgid/mojohaus-dev/5c4d54d4066f4136a406e7101b7703a4%40mailx01.intern.pro-vision.de

i do not consider this question as a blocker for this release, as we always can change the release tag information in github afterwards. so voting for this release should continue independently of the outcome of the discussion.

stefan

>-----Original Message-----
>From: mojoha...@googlegroups.com <mojoha...@googlegroups.com> On
>Behalf Of Anders Hammar
>Sent: Tuesday, March 3, 2020 10:51 PM
>To: mojoha...@googlegroups.com
>Subject: Re: [VOTE] Release Build Helper Maven Plugin 3.1.0
>

>There is a changelog in the generated mojo site:
>https://www.mojohaus.org/build-helper-maven-plugin/github-report.html
>
>But I'm not saying that the release drafter (is that what it's called) is
>bad, I'm just saying that it should be documented in the release process.
>
>/Anders
>

>On Tue, Mar 3, 2020 at 9:18 PM Stefan Seifert <mailto:sseifert@pro-

><mailto:mailto:sseifert@pro-

>>email to mailto:mailto:mojohaus-dev%252Buns...@googlegroups.com.

>>To view this discussion on the web visit
>>https://groups.google.com/d/msgid/mojohaus-

>>dev/9509b0e7d66c402faebf6d584dcc77e5%http://40mailx01.intern.pro-
>vision.de.

>>--
>>You received this message because you are subscribed to the Google
>Groups
>>"mojohaus-dev" group.
>>To unsubscribe from this group and stop receiving emails from it, send
>an

>>email to mailto:mailto:mojohaus-dev%2Bunsu...@googlegroups.com.

>>To view this discussion on the web visit

>>https://groups.google.com/d/msgid/mojohaus-dev/CAKDUN1vGL1qNjo5QTRoUuc-
>>zH8yyo7qoy3JV53D2t-
>>zwE38UxA%http://40mail.gmail.com?utm_medium=email&utm_source=footer.

>
>--
>You received this message because you are subscribed to the Google Groups
>"mojohaus-dev" group.
>To unsubscribe from this group and stop receiving emails from it, send an
>email to mailto:mojohaus-dev%2Bunsu...@googlegroups.com.
>To view this discussion on the web visit
>https://groups.google.com/d/msgid/mojohaus-

>dev/352af0e82c0341d98fb40e684b5a32d8%40mailx01.intern.pro-vision.de.

>--
>You received this message because you are subscribed to the Google Groups
>"mojohaus-dev" group.
>To unsubscribe from this group and stop receiving emails from it, send an
>email to mailto:mojohaus-dev...@googlegroups.com.
>To view this discussion on the web visit
>https://groups.google.com/d/msgid/mojohaus-

>dev/CAKDUN1sumQ0nEDK%2BoMirEDNxSG6%3D8VwCfwHZuAf%2BksaFqgLVhA%40mail.gmai
>l.com?utm_medium=email&utm_source=footer.

[mfried...@gmx.de]

+1 from my side:

I checked the diff for anything unusual (e.g. new unexpected network marketing connections). I executed the new hostname mojo and it did work as announced. I could imagine a FQDN Mode could be handy as well.

Best Regards
Mirko Friedenhagen
—
Sent from my mobile

Am 03.03.20 um 16:25 schrieb Stefan Seifert

> --
> You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.

> To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/9509b0e7d66c402faebf6d584dcc77e5%40mailx01.intern.pro-vision.de.
>

[Stefan Seifert]

the vote has passed:

+1 Mirko Friedenhagen

i will promote the release.

stefan