PR review for license-maven-plugin

61 views
Skip to first unread message

Victor Martinez

unread,
Nov 16, 2017, 4:34:19 AM11/16/17
to mojohaus-dev
Hi there,

I have raised the PR on the license maven plugin to add support for licensesMerge user property: https://github.com/mojohaus/license-maven-plugin/pull/113. There doesn't seem to be much activity on this repo. Another PR has been sitting there since July. How can I get my PR reviewed to be merged and released?

Regards,
Victor

Tony Chemit

unread,
Nov 16, 2017, 4:43:28 AM11/16/17
to mojohaus-dev
Hi,

I will have a look at it next week, and make a release later.

Tony.

Victor Martinez

unread,
Nov 16, 2017, 12:34:28 PM11/16/17
to mojohaus-dev
Awesome, thanks Tony

Victor Martinez

unread,
Nov 30, 2017, 4:44:40 PM11/30/17
to mojohaus-dev
Is there anything I can do to move this PR forward?

Cheers

Victor Martinez

unread,
Jan 3, 2018, 12:07:44 PM1/3/18
to mojohaus-dev
Hi there,

Happy new year, just wanted to ask who is looking after the license-maven-plugin since I have not seen any feedback for a while and I'd like to get a review of the below PR:
-  https://github.com/mojohaus/license-maven-plugin/pull/113 

Thanks

Victor Martinez

unread,
Jan 17, 2018, 6:18:40 AM1/17/18
to mojohaus-dev
Hi,

I just raised a PR to fix the  broken environmental issue within the .travis.yml regarding the oraclejdk7 which it is not supported and therefore all the current open PRs are failing over and over, and therefore affecting the review process.

This is the fix:

Sorry about the spam

Thanks

Reply all
Reply to author
Forward
0 new messages