[VOTE] flatten-maven-plugin 1.2.6

[lasse.k....@gmail.com]

Hi. I would like to release version 1.2.6 of flatten-maven-plugin

See release issue in Github: https://github.com/mojohaus/flatten-maven-plugin/issues/199

It would include two small improvements and one test fix:

(https://github.com/mojohaus/flatten-maven-plugin/issues/57) Prevent interpolation of an activation file
(https://github.com/mojohaus/flatten-maven-plugin/issues/191) Fix FlattenMojoTest on Windows
(https://github.com/mojohaus/flatten-maven-plugin/issues/146) fix: Add lifecycle mapping metadata for M2E (Eclipse)

The snapshot release is available at https://oss.sonatype.org/content/repositories/snapshots/org/codehaus/mojo/flatten-maven-plugin/1.2.6-SNAPSHOT/

Voting open for 72H

[Anders Hammar]

Why isn't the release staged?

http://www.mojohaus.org/development/performing-a-release.html

/Anders

--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/0e87fb61-0783-4707-b313-a7d883021785n%40googlegroups.com.

[lasse.k....@gmail.com]

Yeah. No idea why it does't work as expected with "mvn release:prepare" and "mvn release:perform". So, if someone knows how to fix that problem, it would be great.

[Hervé Boutemy]

what do you mean by "it does't work as expected with "mvn release:prepare" and "mvn release:perform".", please?

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/7b1780e4-ec00-4c8b-98ca-07978520d46cn%40googlegroups.com.

[lasse.k....@gmail.com]

You would expect to be able to complete step "Log into https://oss.sonatype.org/ and "Close" the staging repository." but it is not possible since the staging repository cannot be found even though Maven commands had no errors or warnings related to this.

I don't know much about why the procedure is like this instead of just "mvn deploy", so not sure where to start. Last time with version 1.2.1 it did seem to work just fine, and with other version by other contributors, so maybe it could for someone else.

[Anders Hammar]

Was it ever uploaded to oss.s.o? The build log should say.

/Anders

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/48cc3ea4-8a4e-4b90-95fe-f25cc709b5c0n%40googlegroups.com.

[Hervé Boutemy]

looking at commit history https://github.com/mojohaus/flatten-maven-plugin/commits/master

there is no tag, no "prepare release" commit but 2 "prepare for next iteration" commits

something is going weird, and it's not only at remote repository level

sharing logs would give some concrete fact to investigate

Regards,

Hervé

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAKDUN1uZ1VW7Nd8B4k57HtDHVT4o8bdkLzfJsZ-2-_FzHhAEgA%40mail.gmail.com.

[lasse.k....@gmail.com]

https://oss.sonatype.org/content/repositories/snapshots/org/codehaus/mojo/flatten-maven-plugin/1.2.6-SNAPSHOT/

does contain the generated artifacts as maven-deploy-plugin:2.8.2 deploys them normally and it is the last plugin to execute in the build.

...

    [INFO] Uploaded to ossrh-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/codehaus/mojo/flatten-maven-plugin/1.2.6-SNAPSHOT/flatten-maven-plugin-1.2.6-20210228.110337-2-javadoc.jar.asc (499 B at 1.6 kB/s)
    [INFO] Uploading to ossrh-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/codehaus/mojo/flatten-maven-plugin/1.2.6-SNAPSHOT/maven-metadata.xml
    [INFO] Uploaded to ossrh-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/codehaus/mojo/flatten-maven-plugin/1.2.6-SNAPSHOT/maven-metadata.xml (2.5 kB at 2.6 kB/s)
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time:  08:13 min
    [INFO] Finished at: 2021-02-28T13:03:57+02:00
    [INFO] ------------------------------------------------------------------------
[INFO] phase cleanup
[INFO] Cleaning up after release...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  08:47 min
[INFO] Finished at: 2021-02-28T13:03:57+02:00
[INFO] ------------------------------------------------------------------------

Should there be something else triggered too?

[Hervé Boutemy]

it is pushing version  1.2.6-SNAPSHOT

the Git commit to switch to 1.2.6 is really missing

the issue you have is not tied to repository manager at all: SNAPSHOT version is pushed to SNAPSHOT repository = perfectly expected

your issue is that the commit to prepare 1.2.6 release is not happening

the interesting part of the logs is the release:prepare output, that should provide the right commit: https://maven.apache.org/maven-release/maven-release-plugin/examples/prepare-release.html

This is more your Git setup that would require to be checked

Regards,

Hervé

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/a3cd0207-eb8e-4a8f-a68d-c936c542a819n%40googlegroups.com.

[lasse.k....@gmail.com]

Thanks for the pointers. It was fixed by adding "-Dresume=false", since the plugin was continueing from an earlied dirty state. Now the staging repository has been closed successfully.

Repository: https://oss.sonatype.org/content/repositories/orgcodehausmojo-1188/

Because of the new run, the release version number would be 1.2.7 instead of 1.2.6 but that should not matter. Also the release would include one extra commit (https://github.com/mojohaus/flatten-maven-plugin/commit/d2136165e75d07352cd99bd71e929a213b1df923, the other 3 commits added by Hervé should not make any difference for the release) where mojo-parent has been updated, since that was merged between the two release attempts.

I think it makes sense to extend the time to take part in the release decision to last 72 hours from this moment on.

[Hervé Boutemy]

great news: happy the root cause has been found

I tested and was able to reproduce the build: JDK 11 on Windows...

Regards,

Hervé

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/c82ae462-1bb2-4ed6-968a-687f52eb632fn%40googlegroups.com.

[lasse.k....@gmail.com]

So as there are no votes against or for the release, this one counts as passed. I will prepare the release with version number 1.2.7.