[VOTE] Release Plexus Classworlds version 2.7.0

[Konrad Windszus]

Hi,
I'd like to release version 2.7.0 of the Plexus Classworlds. We solved some issues: https://github.com/codehaus-plexus/plexus-classworlds/milestone/2?closed=1

Staging Repository: https://oss.sonatype.org/content/repositories/plexus-1219.
(Staging) Site: https://codehaus-plexus.github.io/plexus-classworlds/
The preliminary release notes are at https://github.com/codehaus-plexus/plexus-classworlds/releases/tag/plexus-classworlds-2.7.0.

Please vote on the release with either
[ ] +1
[ ] +0
[ ] -1

This release is necessary in order to implement https://issues.apache.org/jira/browse/MNG-7574 in Maven.

The vote is open for 72 hours and will succeed by lazy consensus.
Cheers,
Konrad

[Slawomir Jaranowski]

Hi

Thanks for the release.

Site generated without a reporting profile :-)

We see plexus also has such one.

Missing license body - https://codehaus-plexus.github.io/plexus-classworlds/licenses.html

By the way +1 for release.

--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/E8B62EFD-51A8-47B7-B323-81A8A5F8AB8E%40gmx.de.

--

Sławomir Jaranowski

[Olivier Lamy]

sounds good (we are lazy vote +1 agreement :) ) and usually do not
even need to vote.
I don't understand why you created a release note manually whereas it
was generated automatically as draft by release drafter. (and we can’t use it
now anymore as you created a real note even before the vote passed instead
of a draft...)
would be better to just let release drafter doing the job or only
create draft release until the release is really done.

> --
> You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/E8B62EFD-51A8-47B7-B323-81A8A5F8AB8E%40gmx.de.

--

Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

[Артем Крошенинников]

Just a side note as a reader & user, not a contributor:

I doubt people need endless `update GH actions stuff from version X to another Y`, this is meaningless for the dependency itself. Generating RL with updates *inside* the dependency is useful as it may influence on this library behaviour.

вт, 15 нояб. 2022 г. в 01:08, Olivier Lamy <olive...@gmail.com>:

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAPoyBqS3acUyeRTbKSbcANqZ5cxX9RMeVsFV-eut8XTtQfuL1Q%40mail.gmail.com.

--

Sincerely yours,
Krosheninnikov Artem.

[Olivier Lamy]

Good point!

In such case PR label should be changed to one of those labels 

https://github.com/mojohaus/.github/blob/62d3e600efbbf5e44da2b7a09726913ac55235b8/.github/release-drafter.yml#L55

And they will not be in RL 

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAGTk7vg4zdzh15npwsavcudm0sxku-SSbakWYzfidCN_Fs8vNw%40mail.gmail.com.

[Konrad Windszus]

s.jara...@gmail.com schrieb am Montag, 14. November 2022 um 00:01:41 UTC+1:

Hi

Thanks for the release.

Site generated without a reporting profile :-)

We see plexus also has such one.

Thanks, fixed now. The profile was not mentioned at https://www.mojohaus.org/development/performing-a-release.html#staging-the-release therefore I missed it 

Missing license body - https://codehaus-plexus.github.io/plexus-classworlds/licenses.html

This is probably due to the unclear licensing, see also
- https://github.com/codehaus-plexus/plexus-classworlds/blob/plexus-classworlds-2.7.0/LICENSE-Codehaus.txt

- https://github.com/codehaus-plexus/plexus-classworlds/blob/plexus-classworlds-2.7.0/LICENSE.txt

Not sure which license really applies here, I added https://github.com/codehaus-plexus/plexus-classworlds/issues/74 to track/fix that in the future.

Konrad

 

[Konrad Windszus]

Would be good to have some documentation around that. I had to manually change, because the previous release was not correctly identified (i.e. also changes done in 2.6 have been listed there, don't know why).

Konrad

[Konrad Windszus]

Release was successful, I just pushed out to Maven Central.

Thanks for voting/testing.

Konrad

[Olivier Lamy]

On Fri, 18 Nov 2022 at 20:00, Konrad Windszus <konr...@gmx.de> wrote:
>
> Would be good to have some documentation around that. I had to manually change, because the previous release was not correctly identified (i.e. also changes done in 2.6 have been listed there, don't know why).

yes this usually happen when it's the first gh release of the project.
to prevent this you can use gh cli tool with some option such: gh
release create --notes-start-tag
and so content will not be picked up before the tag passed as an argument
but now we are fine there is this "first" release to release-drafter
will use it as a starting point.

> To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/53d9bda2-b4e5-4cf5-8404-d0be80dbac63n%40googlegroups.com.