[VOTE] Release extra-enforcer-rules:1.1

39 views
Skip to first unread message

Baptiste Mathus

unread,
Nov 26, 2018, 7:20:08 AM11/26/18
to mojoha...@googlegroups.com
Hello everyone,

Staging repository: 

The main change in this release is to add the support for JDK 11 in enforceBytecodeVersion rule
(and JDK 12, and we now even have CI for this, thanks to Sylwester Lachiewicz!).
It also bumps the minimum JDK requirement from Java 5 to Java 6.

Full diff:

You will have noticed with the previous diff that the diff is not very big, hence why I didn't bump to 2.x or so.
At the end of the day, it's still a small-ish release. 

Please vote
 [ ] +1
 [ ] +0
 [ ] -1

Vote open for 72 hours max, and will succeed by lazy consensus as usual.

Thanks!

-- Baptiste

Mirko Friedenhagen

unread,
Nov 26, 2018, 9:41:25 AM11/26/18
to mojoha...@googlegroups.com
-1 from my side

The .travis-ci.yml now does not download alternate versions of Maven anymore and all builds are done with 3.5.2 which is the standard version beneath "Maven home: /usr/local/maven-3.5.2", see e.g.:



--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To post to this group, send email to mojoha...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CANWgJS6F%2BW9mpLRoBgMXV9sZ52PppiJaYoDdO8T_nbxtKabskg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Baptiste Mathus

unread,
Nov 30, 2018, 11:29:52 AM11/30/18
to mojoha...@googlegroups.com
Curious @Mirko : now with https://github.com/mojohaus/extra-enforcer-rules/pull/68 merged and if build is successful on master, would to you consider changing your vote to +1, or would you still want a new release, like 1.1.1, from the new master state?

Thanks!

Mirko Friedenhagen

unread,
Nov 30, 2018, 11:31:51 AM11/30/18
to mojoha...@googlegroups.com
Hello Baptiste,

you get a +1 from my side as I do not expect any problems now . Thanks for releasing!

Best Regards
Mirko Friedenhagen

Sent from my mobile

Am 30.11.18 um 17:29 schrieb Baptiste Mathus

> Curious @Mirko : now with
> https://github.com/mojohaus/extra-enforcer-rules/pull/68 merged and if
> build is successful on master, would to you consider changing your vote to
> +1, or would you still want a new release, like 1.1.1, from the new master
> state?
>
> Thanks!
>
> Le lun. 26 nov. 2018 à 15:41, Mirko Friedenhagen <mfried...@gmx.de> a
> écrit :
>
> > -1 from my side
> >
> > The .travis-ci.yml now does not download alternate versions of Maven
> > anymore and all builds are done with 3.5.2 which is the standard version
> > beneath "Maven home: /usr/local/maven-3.5.2", see e.g.:
> >
> > * https://travis-ci.org/mojohaus/extra-enforcer-rules/jobs/459717116
> > * https://travis-ci.org/mojohaus/extra-enforcer-rules/jobs/459717124
> >
> >
> > Am 26.11.2018 um 13:19 schrieb Baptiste Mathus <bma...@batmat.net>:
> >
> > Hello everyone,
> >
> > Staging repository:
> > https://oss.sonatype.org/content/repositories/orgcodehausmojo-1131/
> >
> > The main change in this release is to add the support for JDK 11 in
> > enforceBytecodeVersion rule
> > (*and* JDK 12, and we now even have CI for this, thanks to Sylwester
> > Lachiewicz!).
> > It also bumps the minimum JDK requirement from Java 5 to Java 6.
> >
> > Full diff:
> >
> > https://github.com/mojohaus/extra-enforcer-rules/compare/extra-enforcer-rules-1.0...extra-enforcer-rules-1.1
> >
> > You will have noticed with the previous diff that the diff is not very
> > big, hence why I didn't bump to 2.x or so.
> > At the end of the day, it's still a small-ish release.
> >
> > Please vote
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Vote open for 72 hours max, and will succeed by lazy consensus as usual.
> >
> > Thanks!
> >
> > -- Baptiste
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "mojohaus-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to mojohaus-dev...@googlegroups.com.
> > To post to this group, send email to mojoha...@googlegroups.com.
> > To view this discussion on the web visit
> > https://groups.google.com/d/msgid/mojohaus-dev/CANWgJS6F%2BW9mpLRoBgMXV9sZ52PppiJaYoDdO8T_nbxtKabskg%40mail.gmail.com
> > <https://groups.google.com/d/msgid/mojohaus-dev/CANWgJS6F%2BW9mpLRoBgMXV9sZ52PppiJaYoDdO8T_nbxtKabskg%40mail.gmail.com?utm_medium=email&utm_source=footer>
> > .
> > For more options, visit https://groups.google.com/d/optout.
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "mojohaus-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to mojohaus-dev...@googlegroups.com.
> > To post to this group, send email to mojoha...@googlegroups.com.
> > To view this discussion on the web visit
> > https://groups.google.com/d/msgid/mojohaus-dev/C9DE4493-F0CD-4436-BA70-B4F08832DB9C%40gmx.de
> > <https://groups.google.com/d/msgid/mojohaus-dev/C9DE4493-F0CD-4436-BA70-B4F08832DB9C%40gmx.de?utm_medium=email&utm_source=footer>
> > .
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
> To post to this group, send email to mojoha...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CANWgJS67KSq%3DgMKj5X64s2RqJ7_5rk-%3Du-ig-kSUfYskXsrEqw%40mail.gmail.com.

Baptiste Mathus

unread,
Nov 30, 2018, 1:37:48 PM11/30/18
to mojoha...@googlegroups.com
Cool thanks a lot! 
Finalizing the 1.1 release then.

Baptiste Mathus

unread,
Nov 30, 2018, 1:44:03 PM11/30/18
to mojoha...@googlegroups.com
The vote succeeded

+1: Mirko and Baptiste
0: nobody
-1: nobody

Proceeding with the rest of the process

Thanks everyone
Reply all
Reply to author
Forward
0 new messages