Re: ServerPushDiscovery: Filter and configuration changes (issue1140001)

[mdst...@google.com]

LGTM (after just a couple more nits)

Thanks for getting this working!


http://page-speed-codereview.appspot.com/1140001/diff/700001/mod_spdy/apache/filters/server_push_discovery_filter.cc
File mod_spdy/apache/filters/server_push_discovery_filter.cc (right):

http://page-speed-codereview.appspot.com/1140001/diff/700001/mod_spdy/apache/filters/server_push_discovery_filter.cc#newcode37
mod_spdy/apache/filters/server_push_discovery_filter.cc:37: void
ReadSessionCookie(apr_table_t* headers) {
Looks like this isn't needed anymore?

http://page-speed-codereview.appspot.com/1140001/diff/700001/mod_spdy/apache/filters/server_push_discovery_filter.cc#newcode96
mod_spdy/apache/filters/server_push_discovery_filter.cc:96: cookie_ss <<
new_session_id;
Please use base::Int64ToString rather than ostringstream for this.

http://page-speed-codereview.appspot.com/1140001/