Re: ServerPushDiscovery: Filter and configuration changes (issue1140001)

[mdst...@google.com]

On 2014/03/25 00:01:23, tommycli wrote:
> mdsteele: I've resolved most of your issues, but this isn't done. The
biggest
> outstanding issue is the util_cookies.h. It doesn't exist in apache
2.2. (See
> below comment).

Ah, okay, that makes more sense.

> One thing I could do is to copy simplified versions of util_cookies.c
into the
> namespace {} of server_push_discovery_filter.cc.

If we're copying any nontrivial amount of code, it should really go in
its own file under third_party, to keep the licensing/copyright clear.
Could we put a copy of util_cookies.{h,c} (or whatever subset of it is
actually needed) under src/third_party/apache/, perhaps modified to be
under a new namespace (so that we don't have symbol conflicts with other
modules)?

http://page-speed-codereview.appspot.com/1140001/