Groups
Groups
Sign in
Groups
Groups
mod-spdy-codereview
Conversations
About
Send feedback
Help
Re: ServerPushDiscovery: Session and Learner classses in common. (issue970001)
1 view
Skip to first unread message
mdst...@google.com
unread,
Jan 10, 2014, 11:14:09 AM
1/10/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to tomm...@chromium.org, bmcq...@google.com, mod-spdy-...@googlegroups.com, re...@page-speed-codereview.appspotmail.com
LGTM. Sorry for the long delay. Just one nit to fix, and then go ahead
and check in.
http://page-speed-codereview.appspot.com/970001/diff/150001/mod_spdy/common/server_push_discovery_learner.cc
File mod_spdy/common/server_push_discovery_learner.cc (right):
http://page-speed-codereview.appspot.com/970001/diff/150001/mod_spdy/common/server_push_discovery_learner.cc#newcode27
mod_spdy/common/server_push_discovery_learner.cc:27: if (EndsWith(url,
".js", false))
Braces for all if/else blocks, please.
http://page-speed-codereview.appspot.com/970001/
Reply all
Reply to author
Forward
0 new messages