Re: ServerPushDiscovery: Session and Learner classses in common. (issue970001)

1 view
Skip to first unread message

mdst...@google.com

unread,
Jan 10, 2014, 11:14:09 AM1/10/14
to tomm...@chromium.org, bmcq...@google.com, mod-spdy-...@googlegroups.com, re...@page-speed-codereview.appspotmail.com
LGTM. Sorry for the long delay. Just one nit to fix, and then go ahead
and check in.


http://page-speed-codereview.appspot.com/970001/diff/150001/mod_spdy/common/server_push_discovery_learner.cc
File mod_spdy/common/server_push_discovery_learner.cc (right):

http://page-speed-codereview.appspot.com/970001/diff/150001/mod_spdy/common/server_push_discovery_learner.cc#newcode27
mod_spdy/common/server_push_discovery_learner.cc:27: if (EndsWith(url,
".js", false))
Braces for all if/else blocks, please.

http://page-speed-codereview.appspot.com/970001/
Reply all
Reply to author
Forward
0 new messages