Re: Step 3 of 3 of SPDY/3.1 support: use shared flow control window within SpdySession (issue1120001)

2 views
Skip to first unread message

mdst...@google.com

unread,
Jan 3, 2014, 2:43:01 PM1/3/14
to hkh...@google.com, mod-spdy-...@googlegroups.com, re...@page-speed-codereview.appspotmail.com

http://page-speed-codereview.appspot.com/1120001/diff/1/mod_spdy/common/spdy_session.cc
File mod_spdy/common/spdy_session.cc (right):

http://page-speed-codereview.appspot.com/1120001/diff/1/mod_spdy/common/spdy_session.cc#newcode640
mod_spdy/common/spdy_session.cc:640: StopSession();
On 2014/01/03 19:29:51, hkhalil wrote:
> Seems like this belongs in a separate CL with separate tests...

Oops, right. Reverted. (I think I added a bunch of those in while
trying to get a recalcitrant test to pass, and forgot to take them back
out when they turned out not to be necessary.)

http://page-speed-codereview.appspot.com/1120001/diff/1/mod_spdy/common/spdy_session.cc#newcode692
mod_spdy/common/spdy_session.cc:692: StopSession();
On 2014/01/03 19:29:51, hkhalil wrote:
> Seems like this belongs in a separate CL with separate tests...

Reverted.

http://page-speed-codereview.appspot.com/1120001/
Reply all
Reply to author
Forward
0 new messages