Re: ServerPushDiscovery: Filter and configuration changes (issue1140001)

[mdst...@google.com]

On 2014/03/26 01:05:38, tommycli wrote:
> I wrote a test for the filter and moved util_cookies to third_party.

> There's something wrong with the patch as-is, as Apache segfaults on
mod_spdy
> somewhere. The breaking change is moving util_cookies to third_party.
I think I
> must have one of the gyps misconfigured.

I don't see any obvious problem with the gyps, but it's certainly
possible that I'm missing something.

When does the segfault occur? At module load time? At
connection/request time?

> Before I dig into debugging this - does this configuration of where to
put
> util_cookies make sense?

Yes, that looks like a good place to put it.

You might try putting all of the symbols in that file within a new C++
namespace and see if that helps at all. Maybe you're getting symbol
conflicts when the shared object gets loaded? (Or maybe I'm way off,
I'm not really sure.)

> Would it make sense to retarget mod_spdy for 2.4 instead? This
ultimately seems
> like a big hack.

Retargeting for 2.4 is a big job, and even if we add 2.4 support (which
would be great), I'd rather not drop 2.2 support. So we'd still need to
solve this issue. /-:


http://page-speed-codereview.appspot.com/1140001/