Re: XAssociatedContentDiscoverer: Add session and tests. (issue898003)

2 views
Skip to first unread message

Bryan McQuade

unread,
Oct 25, 2013, 5:07:29 PM10/25/13
to tomm...@chromium.org, Matthew Steele, Bryan McQuade, mod-spdy-...@googlegroups.com, re...@page-speed-codereview.appspotmail.com
How's 'ServerPushDiscoveryBlah'? I'd prefer that slightly longer name. When I see 'ServerPush' I immediately know what's going on. When I see just 'Push' it is less clear.


On Fri, Oct 25, 2013 at 4:44 PM, <tomm...@chromium.org> wrote:
On 2013/10/22 22:49:27, tommycli wrote:
On 2013/10/22 22:06:57, bmcquade wrote:
> Thanks! The other thing Matthew and I talked about was sending out
all of your
> changes in a separate review, not intended to be checked in, but to
allow us
to
> see what is coming so we can give better feedback on the earlier
CLs. Can you
> create a big CL with all of your changes and send that out so we
have more
> context about what is to come?

That works with me. I'll put something like that together.

XAssociatedContentDiscovererBlah is making for some hugely long class
names.

How about PushDiscoveryBlah? Is that sufficiency descriptive?

http://page-speed-codereview.appspot.com/898003/

Reply all
Reply to author
Forward
0 new messages