Issue 1049 in modpagespeed: We do not always enable (and sometimes disable) gzip for unrewritten resources

[modpag...@googlecode.com]

Status: Accepted
Owner: jef...@google.com
Labels: Type-Defect Priority-Medium

New issue 1049 by jmaes...@google.com: We do not always enable (and
sometimes disable) gzip for unrewritten resources
https://code.google.com/p/modpagespeed/issues/detail?id=1049

I'm doing this with a debug install of mod_pagespeed using
/mod_pagespeed_example.

1) Put mod_pagespeed in passthrough:

ModPagespeedRewriteLevel PassThrough
ModPagespeedDisableFilters add_instrumentation


2) Take a look at content type, http status, and url in mod_pagespeed
example, and whether the results are gzipped when we ask for it. A script:

for f in $(cd $HTDOCS_PATH && find mod_pagespeed_example -name '*.js') ; do
wget http://$HOST:8080/$f --header='accept-encoding: gzip, deflate' -S -O
/dev/null |& egrep 'Content-Encoding|--2015|HTTP/|Content-Type:'; done

What we see is that gzip is not being enabled for .css and .js files that
are being passed through. .html is being gzipped.

3) Attempt the same thing, with gzip switched on for text/css and
application/javascript.

This appears to work in my configuration, but we've had reports of it
failing when compression worked with ModPagespeed off. But really we
should enable compression for any content type we don't think we should
explicitly blacklist (eg the image types and woff / woff2).



--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[modpag...@googlecode.com]

Updates:
Cc: ukkpo...@gmail.com

Comment #1 on issue 1049 by jmaes...@google.com: We do not always enable

(and sometimes disable) gzip for unrewritten resources
https://code.google.com/p/modpagespeed/issues/detail?id=1049

(No comment was entered for this change.)

[modpag...@googlecode.com]

Updates:
Status: RequestClarification

Comment #2 on issue 1049 by jef...@google.com: We do not always enable (and

sometimes disable) gzip for unrewritten resources
https://code.google.com/p/modpagespeed/issues/detail?id=1049

Testing, I think mod_pagespeed enables gzip on any file it touches. So
html, .pagespeed. resources, ipro resources. It shouldn't be disabling
gzip (which I've still not seen) but this limited enabling I think is
actually fine. In normal usage we'll be running core filters, in which
case the urls we emit are .pagespeed. resources, and we'll have ipro on so
that other resources also get optimized (including gzipping).

So what I've been able to reproduce is fine (though not perfect), but if we
are disabling gzip in any case (relative to setting 'ModPagespeed
unplugged' in the config) that's bad and it's something we should fix.

[modpag...@googlecode.com]

Comment #3 on issue 1049 by jcro...@google.com: We do not always enable

(and sometimes disable) gzip for unrewritten resources
https://code.google.com/p/modpagespeed/issues/detail?id=1049

this issue has been migrated to github:
https://github.com/pagespeed/mod_pagespeed/issues/1049