Incorrect Core Filters Listed On Developers Page

[Mark Kennedy]

Hi,

On this page which lists the filters, the filters listed at the top of the page as core filters, doesn't match up to the table further down in the page.

https://developers.google.com/speed/pagespeed/module/config_filters

For example, the page says that the core set of filters contains combine_javascript, however the table further down the page says "No" to combine_javascript being included int he core filters.

I havn't checked others but I think an audit of whats enabled in core filters and whats detailed on the page needs to be done. Is this the right place to report this?

Regards,

Mark

[Jeff Kaufman]

Thanks for the report! I'll fix the doc.

In the code, core filters listed in rewriter/rewrite_options.cc in
kCoreFilterSet, if you want to see the final authority on which ones
are core:

RewriteOptions::kAddHead,
RewriteOptions::kCombineCss,
RewriteOptions::kCombineJavascript,
RewriteOptions::kConvertGifToPng, // rewrite_images
RewriteOptions::kConvertJpegToProgressive, // rewrite_images
RewriteOptions::kConvertJpegToWebp, // rewrite_images
RewriteOptions::kConvertMetaTags,
RewriteOptions::kConvertPngToJpeg, // rewrite_images
RewriteOptions::kExtendCacheCss, // extend_cache
RewriteOptions::kExtendCacheImages, // extend_cache
RewriteOptions::kExtendCacheScripts, // extend_cache
RewriteOptions::kFallbackRewriteCssUrls,
RewriteOptions::kFlattenCssImports,
RewriteOptions::kInlineCss,
RewriteOptions::kInlineImages, // rewrite_images
RewriteOptions::kInlineImportToLink,
RewriteOptions::kInlineJavascript,
RewriteOptions::kJpegSubsampling, // rewrite_images
RewriteOptions::kRecompressJpeg, // rewrite_images
RewriteOptions::kRecompressPng, // rewrite_images
RewriteOptions::kRecompressWebp, // rewrite_images
RewriteOptions::kResizeImages, // rewrite_images
RewriteOptions::kRewriteCss,
RewriteOptions::kRewriteJavascript,
RewriteOptions::kRewriteStyleAttributesWithUrl,
RewriteOptions::kStripImageColorProfile, // rewrite_images
RewriteOptions::kStripImageMetaData, // rewrite_images

> --
> You received this message because you are subscribed to the Google Groups
> "mod-pagespeed-discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to mod-pagespeed-di...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/mod-pagespeed-discuss/72f0eb16-9e83-4c34-b5d5-e1127905daa9%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Mark Kennedy]

Thats great, thanks Jeff.

Mark

> email to mod-pagespeed-discuss+unsub...@googlegroups.com.