Compiler error when building boringssl

[Robert Munteanu]

Hi,

My openSUSE builds recently started failing for Tumbleweed ( which is a rolling release, so more a less or moving target in terms of the toolchain ). The specific error is at the end of the email. However I'm curious whether boringssl compilation can be skipped - I'm using use_system_libs = 1 and boringssl should not be necessary.

The build errors are

[  212s]   CC(target) out/Release/obj.target/openssl/third_party/boringssl/src/crypto/bn/add.o
[  212s] third_party/boringssl/src/crypto/bio/socket_helper.c: In function 'bio_ip_and_port_to_socket_and_addr':
[  212s] third_party/boringssl/src/crypto/bio/socket_helper.c:42:19: error: storage size of 'hint' isn't known
[  212s]    struct addrinfo hint, *result, *cur;
[  212s]                    ^
[  212s] third_party/boringssl/src/crypto/bio/socket_helper.c:51:9: warning: implicit declaration of function 'getaddrinfo' [-Wimplicit-function-declaration]
[  212s]    ret = getaddrinfo(hostname, port_str, &hint, &result);
[  212s]          ^
[  212s] third_party/boringssl/src/crypto/bio/socket_helper.c:54:27: warning: implicit declaration of function 'gai_strerror' [-Wimplicit-function-declaration]
[  212s]      ERR_add_error_data(1, gai_strerror(ret));
[  212s]                            ^
[  212s] third_party/boringssl/src/crypto/bio/socket_helper.c:60:36: error: dereferencing pointer to incomplete type 'struct addrinfo'
[  212s]    for (cur = result; cur; cur = cur->ai_next) {
[  212s]                                     ^
[  212s] third_party/boringssl/src/crypto/bio/socket_helper.c:79:3: warning: implicit declaration of function 'freeaddrinfo' [-Wimplicit-function-declaration]
[  212s]    freeaddrinfo(result);
[  212s]    ^
[  212s] third_party/serf/openssl.target.mk:616: recipe for target 'out/Release/obj.target/openssl/third_party/boringssl/src/crypto/bio/socket_helper.o' failed
[  212s] make: *** [out/Release/obj.target/openssl/third_party/boringssl/src/crypto/bio/socket_helper.o] Error 1
[  212s] make: *** Waiting for unfinished jobs....
[  212s] error: Bad exit status from /var/tmp/rpm-tmp.YI3n8A (%build)

GCC version is

$ gcc -v

Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib64/gcc/x86_64-suse-linux/5/lto-wrapper
Target: x86_64-suse-linux
Configured with: ../configure --prefix=/usr --infodir=/usr/share/info --mandir=/usr/share/man --libdir=/usr/lib64 --libexecdir=/usr/lib64 --enable-languages=c,c++,objc,fortran,obj-c++,java,ada,go --enable-checking=release --with-gxx-incl
ude-dir=/usr/include/c++/5 --enable-ssp --disable-libssp --disable-libvtv --enable-libmpx --disable-plugin --with-bugurl=http://bugs.opensuse.org/ --with-pkgversion='SUSE Linux' --disable-libgcj --with-slibdir=/lib64 --with-system-zlib -
-enable-__cxa_atexit --enable-libstdcxx-allocator=new --disable-libstdcxx-pch --enable-version-specific-runtime-libs --enable-linker-build-id --enable-linux-futex --program-suffix=-5 --without-system-libunwind --enable-multilib --with-ar
ch-32=i586 --with-tune=generic --build=x86_64-suse-linux --host=x86_64-suse-linux
Thread model: posix
gcc version 5.1.1 20150622 [gcc-5-branch revision 224722] (SUSE Linux)

Thanks,

Robert

[Jeffrey Crowell]

If you're using the system libraries, compiling boringssl shouldn't be needed or compiled.

I've opened a bug here https://github.com/pagespeed/mod_pagespeed/issues/1139 to track it.

What version of openssl and ssl-dev is currently in tumbleweed?

--
You received this message because you are subscribed to the Google Groups "mod-pagespeed-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mod-pagespeed-di...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mod-pagespeed-discuss/37e18475-3738-4017-b9e7-c7ae89dd20d3%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Robert Munteanu]

On Tue, Sep 8, 2015 at 5:32 PM, 'Jeffrey Crowell' via
mod-pagespeed-discuss <mod-pagesp...@googlegroups.com> wrote:
> If you're using the system libraries, compiling boringssl shouldn't be
> needed or compiled.
>
> I've opened a bug here
> https://github.com/pagespeed/mod_pagespeed/issues/1139 to track it.

Thanks!

>
> What version of openssl and ssl-dev is currently in tumbleweed?

$ openssl version
OpenSSL 1.0.2d-fips 9 Jul 2015

Not sure what you bean by ssl-dev.

Robert

> You received this message because you are subscribed to a topic in the
> Google Groups "mod-pagespeed-discuss" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/mod-pagespeed-discuss/M77Gqb5Kewc/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to

> mod-pagespeed-di...@googlegroups.com.
> To view this discussion on the web visit

> https://groups.google.com/d/msgid/mod-pagespeed-discuss/CA%2B7dWMErhVWfk1%2BK%2BMMKKC7QaH0npU2jsJp%2BEPdC-csA%2BfW-5A%40mail.gmail.com.

>
> For more options, visit https://groups.google.com/d/optout.

--
http://robert.muntea.nu/

[Jeffrey Crowell]

doesn't seem like tumbleweed has bumped openssl since the builds were working on 1.9.32.4

$ openssl version
OpenSSL 1.0.2d-fips 9 Jul 2015

Has your build script/process changed at all since then?

To view this discussion on the web visit https://groups.google.com/d/msgid/mod-pagespeed-discuss/CAC8ULPaPMZNww_sO7pXFwjANMjj1qEv%3D4KzGbAOi774pdxhQ%3Dg%40mail.gmail.com.

[Robert Munteanu]

On Tue, Sep 8, 2015 at 6:19 PM, 'Jeffrey Crowell' via
mod-pagespeed-discuss <mod-pagesp...@googlegroups.com> wrote:
> doesn't seem like tumbleweed has bumped openssl since the builds were
> working on 1.9.32.4
>
> $ openssl version
> OpenSSL 1.0.2d-fips 9 Jul 2015
>
> Has your build script/process changed at all since then?

No changes that I'm aware of that could affect the result. As usual, I
suspect the libraries/toolchain using more recent versions are to
'blame'.

Robert

> https://groups.google.com/d/msgid/mod-pagespeed-discuss/CA%2B7dWMHAS%2B5X5mesHvcb_dz7OYkcTR2wghpex90WWBQYTd-TyQ%40mail.gmail.com.

[Jeffrey Crowell]

See https://github.com/pagespeed/mod_pagespeed/pull/1150 for a fix to the build error, this will be included in the next beta and stable releases.

To view this discussion on the web visit https://groups.google.com/d/msgid/mod-pagespeed-discuss/CAC8ULPZ3yMzEKkNP%3DNqU3PBNkz1D3%3DJe4pgjzSny774cYm9W5Q%40mail.gmail.com.

[Robert Munteanu]

On Wed, Oct 7, 2015 at 6:09 PM, 'Jeffrey Crowell' via
mod-pagespeed-discuss <mod-pagesp...@googlegroups.com> wrote:
> See https://github.com/pagespeed/mod_pagespeed/pull/1150 for a fix to the
> build error, this will be included in the next beta and stable releases.

Applied, thank you.

Robert

--
http://robert.muntea.nu/