Bug in prioritize_critical_css

[theartofweb]

ref: http://www.charlottepass.com.au/lodges

The CSS code from http://cdn.charlottepass.com.au/shadowbox/shadowbox.css includes:

#sb-loading-inner span{background:url(/shadowbox/loading.gif) no-repeat; ...

but the prioritised/inlined CSS changes this to:

#sb-loading-inner span{background:url(http://cdn.charlottepass.com.au/shadowbox/shadowbox/loading.gif) no-repeat; ...

(the directory is being included twice creating a broken link)

[Shawn Ligocki]

Hm, I cannot reproduce this locally, could you post (or email me privately) your configuration?

-Shawn

[theartofweb]

This problem looked to have fixed itself yesterday, but is happening again today.

The CSS from here:

http://cdn.charlottepass.com.au/shadowbox/shadowbox.css

...

#sb-loading-inner span{background:url(/shadowbox/loading.gif) no-repeat;padding-left:34px;display:inline-block;}

#sb-nav-close{background-image:url(/shadowbox/close.png);}

#sb-nav-next{background-image:url(/shadowbox/next.png);}

#sb-nav-previous{background-image:url(/shadowbox/previous.png);}

#sb-nav-play{background-image:url(/shadowbox/play.png);}

#sb-nav-pause{background-image:url(/shadowbox/pause.png);}

...

Appears in the prioritised css style tag with incorrect image paths:

http://www.charlottepass.com.au/lodges

<style>

...

#sb-loading-inner span{background:url(http://cdn.charlottepass.com.au/shadowbox/shadowbox/loading.gif) no-repeat;padding-left:34px;display:inline-block}

...

#sb-nav-close{background-image:url(http://cdn.charlottepass.com.au/shadowbox/shadowbox/close.png)}

#sb-nav-next{background-image:url(http://cdn.charlottepass.com.au/shadowbox/shadowbox/next.png)}

#sb-nav-previous{background-image:url(http://cdn.charlottepass.com.au/shadowbox/shadowbox/previous.png)}

#sb-nav-play{background-image:url(http://cdn.charlottepass.com.au/shadowbox/shadowbox/play.png)}

#sb-nav-pause{background-image:url(http://cdn.charlottepass.com.au/shadowbox/shadowbox/pause.png)}

...

</style>

I'll keep monitoring to see if it changes again.  Strange (-; 

[Jud Porter]

I see the issue on your site, and I'm able to replicate with a local proxy. It looks like an interaction with combine_css is causing a problem. If I view http://www.charlottepass.com.au/lodges?ModPagespeedFilters=-combine_css and refresh a couple times the URLs in the inlined critical css look correct. We'll work out a fix for this, but if this is causing issues in the meantime, you can disable combine_css as a workaround.

[theartofweb]

Great.  The problem has gone again now - possibly a side effect of hitting the page with combine_css disabled(?).  It's not causing a lot of problems because the correct CSS is always post-loaded.  Just some 404 error from the prioritised CSS.

[Jud Porter]

Just to follow up here, we are able to track down the problem and submitted a fix last week to resolve it (https://code.google.com/p/modpagespeed/source/detail?r=2934). If you're building from source, could you try updating and see if that fixes the problem for you? Otherwise an upcoming beta release will include it.

[theartofweb]

After updating to the latest binary (1.5.27.2) we haven't seen these errors any more, for at least a couple of days.