inline_preview_images changed behaviour in 1.5.27.2?

4 views
Skip to first unread message

theartofweb

unread,
May 8, 2013, 5:45:36 AM5/8/13
to mod-pagespeed...@googlegroups.com

The larger banner photo is no longer being inlined.


These smaller photos are still being inlined.

Settings:

    ModPagespeedEnableFilters prioritize_critical_css
    ModPagespeedEnableFilters inline_preview_images
    ModPagespeedMinImageSizeLowResolutionBytes 5120

Matt Atterbury

unread,
May 8, 2013, 8:57:20 AM5/8/13
to theartofweb, mod-pagespeed-beta-testers
Hi,

It looks to me like the default max size for inlined images is 2kb and these are bigger than that.
It's possible that we (incorrectly) ignored that limit for lazyload_images previously, but I expect that if you set it higher they will be inlined:
ModPagespeedImageInlineMaxBytes 4096

cheers, m.
--
"Klaatu barada nikto"                          (754) 444-6288

theartofweb

unread,
May 8, 2013, 9:20:49 AM5/8/13
to mod-pagespeed...@googlegroups.com, theartofweb
Sorry, but I was referring to "inline_preview_images" and not "inline_images" which we don't use.

AFAIK the former has only a 'Min' cutoff setting while the latter only has a 'Max' value which defaults the 2kb, but in the current beta release it looks as through there might also be a 'Max' cutoff for "inline_preview_images"?

Matt Atterbury

unread,
May 8, 2013, 9:34:13 AM5/8/13
to theartofweb, mod-pagespeed-beta-testers
Ah, my bad. I can't see an obvious reason why it's not inlining them - it looks like it should.

Jud Porter

unread,
May 8, 2013, 5:59:36 PM5/8/13
to Matt Atterbury, theartofweb, mod-pagespeed-beta-testers
I don't have a final answer for you yet, but a couple things I've observed.

First off, the main banner looks like it has one of a few random images on it. Unfortunately, our current solution for detecting critical images doesn't deal well with this case. The behavior I am seeing is that one of the images gets identified as critical. Then on a reload, a different image will be displayed and mod_pagespeed will not correctly identify it as critical. For example, if I visit www.simnet.net.au/?ModPagespeedFilters=inline_preview_images and refresh several times, I do see one of the 8 or so banner images consistently being inlined.

However, it also appears that there is something else going on that is preventing any images from being inlined by default. If I refresh the main page several times, I don't see any images being inlined. Further, if I view http://www.simnet.net.au/?ModPagespeedFilters=+inline_preview_images I don't get any inlined images, where as with just ModPagespeedFilters=inline_preview_images (without the +) I do. I'm worried there is a filter interaction issue here. Do you have any other filters besides prioritize_critical_css and inline_preview_images enabled?

Thanks,
Jud

theartofweb

unread,
May 9, 2013, 6:55:16 AM5/9/13
to mod-pagespeed...@googlegroups.com, Matt Atterbury, theartofweb
I can confirm that the random banner is the problem.  After flushing the cache and then displaying only the same photo every time that banner was consistently inline_previewed.  In the previous betas all of the photos were inline_previewed so that is new behaviour.

The other images are being skipped because we set the lower cutoff to 5kb for inline_preview_images.
Reply all
Reply to author
Forward
0 new messages