GlobalTitle getInstance fix me comment

[Yeng Asus]

Hi All,

I saw following 'fixme' comment on creating GT0100 address. Could you please let me know the error of that so that i can fix it if it is possible. I am going to use GT0100 and i am afraid if there is any issue with a address created by following method..  

 /**
     * Global title contains translation type, numbering plan, encoding scheme
     * and nature of address indicator.
     *
     * @param tt
     *            translation type.
     * @param np
     *            numbering plan
     * @param noa
     *            nature of address indicator.
     * @param digits
     *            the address string, if number of digits even the BCD even
     *            encoding scheme is used and BCD odd otherwise.
     * @return Global title instance.
     */
    public static GlobalTitle getInstance(int tt, NumberingPlan np, NatureOfAddress noa, String digits) {
        // FIXME: this construction is wrong
        return new GT0100(tt, np, noa, digits);
    }


Thank you
Regards
Lasith

[Amit Bhayani]

Hi Lasith,

Can't recall why this comment was added.

But the creation of instance looks good to me and more over this same has been tested with multiple MSC/HLR's. 

Amit.