Small syntax patches

[Emmanuel Blot]

Hi,

While building Minix 3 kernel for ARMv7a with clang 3.5, I encountered
a couple of syntax issues.
The attached patches are not tied to a specific version of the
compiler, the issue remain silent with the previous version of clang
(3.4).

HTH,
Manu

[David van Moolenbroek]

Just a quick post to mention that your work is highly appreciated and certainly has not been forgotten! We'll get to these patches as soon as possible.

Regards,
David

[Sambuc Lionel]

Hello Emmanuel,


Sorry for the delay. I have imported all but one patches. The one I didn't import should instead be submitted to the NetBSD project. I'll keep it around, and send it as part of a couple of other changes I have, unless you want to do it yourself. It might take me a couple of weeks though.

The patch in question is "0002-Fix-warnings-for-missing-declarations-in-libc-ssp"

For the other patches, Here are the gerrit changes. I took the liberty of adapting the commit message to our formatting rules, I hope it is OK with you.

http://gerrit.minix3.org/2955 Fix format string for size_t types
http://gerrit.minix3.org/2956 Fix unused variable warnings
http://gerrit.minix3.org/2957 Fix incorrect sanity check
http://gerrit.minix3.org/2958 arm: Make sure __k_unpaged_MINIX is first


Regards,

Lionel

> --
> You received this message because you are subscribed to the Google Groups "minix-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to minix-dev+...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Emmanuel Blot]

Hi Lionel,

> Sorry for the delay. I have imported all but one patches.

Thanks for applying them.

> The one I didn't import should instead be submitted to the NetBSD project. I'll keep it around, and send it as part of a couple of other changes I have, unless you want to do it yourself.

There is no hurry for the NetBSD patch, so I think it is better you
deal with it along with the other changes.

> For the other patches, Here are the gerrit changes. I took the liberty of adapting the commit message to our formatting rules, I hope it is OK with you.

Absolutely, no problem.
If you have a document about these formatting rules, let me know so I
can try to apply them next time.

I have a couple of them ready, but as I'm using a repository that is
not organised as the official one, I need to port them first.

If there is a better way to submit patches that posting them to the
list (github pull request, ...?), let me know as well.

Thanks,
Manu.

[Lionel Sambuc]

On 03/18/2015 11:12 AM, Emmanuel Blot wrote:
> Hi Lionel,
>
>> Sorry for the delay. I have imported all but one patches.
> Thanks for applying them.
>
>> The one I didn't import should instead be submitted to the NetBSD project. I'll keep it around, and send it as part of a couple of other changes I have, unless you want to do it yourself.
> There is no hurry for the NetBSD patch, so I think it is better you
> deal with it along with the other changes.
>
>> For the other patches, Here are the gerrit changes. I took the liberty of adapting the commit message to our formatting rules, I hope it is OK with you.
> Absolutely, no problem.
> If you have a document about these formatting rules, let me know so I
> can try to apply them next time.

Here it is, nothing complex really:
- One title line, of maximum 52 characters
- One blank line
- Commit message, wrapped at 72 characters, which gives more details,
if needed.

This page seems surprisingly incomplete, I will updating it:
http://wiki.minix3.org/doku.php?id=developersguide:commitmessages

> I have a couple of them ready, but as I'm using a repository that is
> not organised as the official one, I need to port them first.

If you wish, you can now send GitHub pull request against the official
minix3 repository mirror we have there.
(https://github.com/Stichting-MINIX-Research-Foundation/minix)

> If there is a better way to submit patches that posting them to the
> list (github pull request, ...?), let me know as well.
>
> Thanks,
> Manu.
>

Regards,

Lionel