MIRtoolbox migration

25 views
Skip to first unread message

Olivier Lartillot

unread,
Jul 23, 2019, 1:41:21 PM7/23/19
to miningsuite-dev
Hi,

I create this new thread to document the integration of MIRtoolbox operators, following the migration tests currently being developed by Habib.

This mail is about miraudio:

- I have added explanation of ‘Mono’ -> ‘Mix’ in the wiki [1]

- I have also explained ’TrimStart/End’ -> ‘JustStart/End’ in the wiki
To answer the questions in migration.xlsb, yes, ’Trim’ is still required, but apart from that they work the same.

- I have explained in the wiki that ‘Channel’ in MIRtoolbox is replaced by both ‘Channel’ and ‘FreqBand’ in MiningSuite

- While checking ’Trim’, I discovered that there was a bug: the time positions were shifted. I corrected the bug and committed the fix to the main branch. But this raises an issue: ideally, to compare results, we should not compare only the actual data (“Y data”) but also the X-axis positions that have been stored (or are automatically generated). But maybe we can ignore this issue and only compare Y data.

- While debugging that issue, I discovered that the problem also appears in ‘Extract’, but only when the input is an actual sig.Signal data:

s = sig.signal('ragtime.wav’)
sig.signal(s, ‘Extract’, 1, 2, ’s’).      % correct result

sig.signal('ragtime.wav’)
s = sig.ans
sig.signal(s, ‘Extract’, 1, 2, ’s’)      %  incorrect result

This is because there are two ‘Extract’ routine. In the first case, we directly load the part of the file we are interested in; in the second case, we select a subpart from a signal that already exists.

So if we plan, at some point (not this summer, I guess), to compare the X data too (cf my previous point), then it would be good to test both configurations shown in the examples above.

By the way, it seems that the code for ‘Extract’ in seconds is missing in the migration script?

- I mentioned the options from MIRtoolbox that are not integrated in MiningSuite, both in [1] and [2].

- I mentioned the new option in MiningSuite in [3]: ‘Detrend’.
‘Point’ and ‘Dim’ relate to things outside MIRtoolbox domain.

Olivier Lartillot

unread,
Aug 2, 2019, 4:30:12 AM8/2/19
to miningsuite-dev
Migration of mirframe and mirfilterbank completed.

I added ‘%’ unit in ‘FrameHop’ so that it works the same way as in MIRtoolbox.

It was possible to use the keyword ‘Hop’ instead of ‘FrameHop’, but there was a conflict with the keyword ‘Hop’ also used in mirfilterbank. From now on, only ‘FrameHop’ can be used in sig.frame.

I added the section ‘Accessible Output’ in sig.frame doc.

2019/07/23 19:41、Olivier Lartillot <olart...@gmail.com>のメール:

Olivier Lartillot

unread,
Nov 29, 2019, 1:48:40 PM11/29/19
to miningsuite-dev
Migration of mirenvelope completed.

Olivier Lartillot

unread,
Jan 28, 2020, 5:10:19 PM1/28/20
to miningsuite-dev
Migration of mirspectrum completed.

‘Phase’ is toggled off by default in sig.spectrum.
Reply all
Reply to author
Forward
0 new messages