Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

CMFCPropertyGridCtrl - Get the value from the grid

1,685 views
Skip to first unread message

dushkin

unread,
Jun 10, 2010, 9:25:10 AM6/10/10
to
Hi All,
I have an MFC application with a TreeView and a CDockablePane
Properties Window.

When I select a tree item - I display its properties in the properties
window. That works.

But I don't know how to change the tree item properties when I change
the values in the properties window. My problem is in getting the
values from the properties grid.

I tried to override EndEditItem method like this:

BOOL CMyMFCPropertyGridCtrl::EndEditItem(BOOL bUpdateData)
{
CMFCPropertyGridProperty* currProperty = GetCurSel();

if(currProperty)
{
//I don't like this implementation! Any suggestions???
((CMyTreeView*)(((CMainFrame*) AfxGetMainWnd()))->GetActiveView()))-
>UpdateTreeItemFromPropWnd(currProperty->GetName(), currProperty-
>GetValue());
}
return CMFCPropertyGridCtrl::EndEditItem();
}

I an trying to catch the event of ending the value editing. But what
is this "ending" of this operation. For example, when I edit and press
"return" button - the event is not called!

Any help will be blessed.
Thanks!

dushkin

unread,
Jun 13, 2010, 2:21:21 AM6/13/10
to
Help... anyone??? :-(

dushkin

unread,
Jun 14, 2010, 3:12:05 AM6/14/10
to
On Jun 13, 9:21 am, dushkin <talt...@gmail.com> wrote:
> Help... anyone??? :-(

Well, lucky me to find the solution... `-)

I derived a class from CMFCPropertyGridProperty and overridden
OnEndEdit().

The default implementation of OnEditEnd() is something like:

ASSERT_VALID(this);

m_bInPlaceEdit = FALSE;
m_bButtonIsFocused = FALSE;

OnDestroyWindow();

//new line will come here...

return TRUE;

So I added the following line, right after the OnDestroyWindow() line:

((CMyView*)(((CMainFrame*)(AfxGetMainWnd()))->GetActiveView()))-
>UpdateTreeItemFromPropWnd(GetName(), GetValue());

I know it is not such an elegant solution, but at least it works.
I will try now to find a more neater way to update the tree view,
maybe with some kind of listeners...

Joseph M. Newcomer

unread,
Jun 21, 2010, 4:43:14 PM6/21/10
to
See below...

On Thu, 10 Jun 2010 06:25:10 -0700 (PDT), dushkin <dus...@012.net.il> wrote:

>Hi All,
>I have an MFC application with a TreeView and a CDockablePane
>Properties Window.
>
>When I select a tree item - I display its properties in the properties
>window. That works.
>
>But I don't know how to change the tree item properties when I change
>the values in the properties window. My problem is in getting the
>values from the properties grid.
>
>I tried to override EndEditItem method like this:
>
>BOOL CMyMFCPropertyGridCtrl::EndEditItem(BOOL bUpdateData)
>{
> CMFCPropertyGridProperty* currProperty = GetCurSel();
>
> if(currProperty)
> {
> //I don't like this implementation! Any suggestions???
> ((CMyTreeView*)(((CMainFrame*) AfxGetMainWnd()))->GetActiveView()))-
>>UpdateTreeItemFromPropWnd(currProperty->GetName(), currProperty-
>>GetValue());

****
You're right not to like this code. It is horrible, and essentially a nightmare. The
CORRECT approach is to SendMessage to the main frame a user-defined message, e.g.,
CString propertyname;
CString newvalue;
...fetch these from the property pane...
AfxGetMainWnd()->SendMessage(UWM_PROPERTY_CHANGED,
(LPARAM)&propertyname,
(WPARAM)&newvalue);
and stop right there.

What I would probably do in the mainframe is send the message to the current view, which
would call a method of the CDocument-class,
void CMyDocument::SetProp(const CString & propname, const CString & value);
and let it worry about what gets set.

The downside is that every view has to have a handler for this message, since you don't
know which view might be active.

LRESULT OnPropertyChange(WPARAM wParam, LPARAM lParam)
{
CString * prop = (CString *)wParam;
CString * val = (CString *)lParam;
GetDocument()->SetProp(*prop, *val);
return 0;
}

Always maintain abstraction. When you find yourself doing horrible casts and having to
include header files that you should not need, you have a bad architecture.
joe
****


> }
> return CMFCPropertyGridCtrl::EndEditItem();
>}
>
>I an trying to catch the event of ending the value editing. But what
>is this "ending" of this operation. For example, when I edit and press
>"return" button - the event is not called!

****
I don't have a good answer for that problem. However, there are some fascinating problems
about how <enter> is handled when controls are embedded in MFC views; the classic one is
how to handle <enter> when editing a tree-control item (the code, however, is massively
buggy; I discuss this in my MSDN Errors and Omissions articles)
joe
****


>
>Any help will be blessed.
>Thanks!

Joseph M. Newcomer [MVP]
email: newc...@flounder.com
Web: http://www.flounder.com
MVP Tips: http://www.flounder.com/mvp_tips.htm

Joseph M. Newcomer

unread,
Jun 21, 2010, 4:45:04 PM6/21/10
to
See below...

On Mon, 14 Jun 2010 00:12:05 -0700 (PDT), dushkin <tal...@gmail.com> wrote:

>On Jun 13, 9:21 am, dushkin <talt...@gmail.com> wrote:
>> Help... anyone??? :-(
>
>Well, lucky me to find the solution... `-)
>
>I derived a class from CMFCPropertyGridProperty and overridden
>OnEndEdit().

****
I would have thought this was what you were *starting from*.
****


>
>The default implementation of OnEditEnd() is something like:
>
> ASSERT_VALID(this);
>
> m_bInPlaceEdit = FALSE;
> m_bButtonIsFocused = FALSE;
>
> OnDestroyWindow();
>
> //new line will come here...
>
> return TRUE;
>
>So I added the following line, right after the OnDestroyWindow() line:
>
> ((CMyView*)(((CMainFrame*)(AfxGetMainWnd()))->GetActiveView()))-
>>UpdateTreeItemFromPropWnd(GetName(), GetValue());

****
As I indicated in an earilier reply, there is nothing justifiable about any part of the
above code. You should not be casting the AfxGetMainWnd to anything, and the very
presence of CMyView* indicates a deep design error that should not exist.
joe

>
>I know it is not such an elegant solution, but at least it works.
>I will try now to find a more neater way to update the tree view,
>maybe with some kind of listeners...

Mehmet Ata BODUR

unread,
Sep 1, 2010, 7:44:49 AM9/1/10
to
I succeeded in doing this. The way I did is create a virtual base class say "MyTreeItem". Have the functions virtual BOOL SetOptns(CMFCPropertyGridCtrl* pPropLst)=0;
virtual LRESULT OnPropertyChanged(WPARAM wparam, LPARAM lparam)=0;
and variables:
static MyTreeItem* m_pCaptured;
TV_INSERTSTRUCT tvinsert;
in it. Your each tree item may refer to a class. Derive your each class from "MyTreeItem" Set LPARAM of tvinsert to the child class itself.

In the tree use:
afx_msg void OnTvnSelchanging(NMHDR *pNMHDR, LRESULT *pResult);
afx_msg void OnTvnSelchanged(NMHDR *pNMHDR, LRESULT *pResult);

functions.

In those functions use GetItemData with casting result to MyTreeItem as:

MyTreeItem* pItem=(MyTreeItem*)this->GetItemData(this->hNewSel);
pItem->SetOptns(........);

I don't know if I have been able to explain neatly... Once you succeed everything is straight...

> On Thursday, June 10, 2010 9:25 AM dushkin wrote:

> Hi All,
> I have an MFC application with a TreeView and a CDockablePane
> Properties Window.
>
> When I select a tree item - I display its properties in the properties
> window. That works.
>

> But I do not know how to change the tree item properties when I change


> the values in the properties window. My problem is in getting the
> values from the properties grid.
>
> I tried to override EndEditItem method like this:
>
> BOOL CMyMFCPropertyGridCtrl::EndEditItem(BOOL bUpdateData)
> {
> CMFCPropertyGridProperty* currProperty = GetCurSel();
>
> if(currProperty)
> {

> //I do not like this implementation! Any suggestions???
> ((CMyTreeView*)(((CMainFrame*) AfxGetMainWnd()))->GetActiveView()))-
> }


> return CMFCPropertyGridCtrl::EndEditItem();
> }
>
> I an trying to catch the event of ending the value editing. But what
> is this "ending" of this operation. For example, when I edit and press
> "return" button - the event is not called!
>
> Any help will be blessed.
> Thanks!


>> On Sunday, June 13, 2010 2:21 AM dushkin wrote:

>> Help... anyone??? :-(


>>> On Monday, June 14, 2010 3:12 AM dushkin wrote:

>>> Well, lucky me to find the solution... `-)
>>>
>>> I derived a class from CMFCPropertyGridProperty and overridden
>>> OnEndEdit().
>>>

>>> The default implementation of OnEditEnd() is something like:
>>>
>>> ASSERT_VALID(this);
>>>

>>> m_bInPlaceEdit =3D FALSE;
>>> m_bButtonIsFocused =3D FALSE;


>>>
>>> OnDestroyWindow();
>>>
>>> //new line will come here...
>>>
>>> return TRUE;
>>>
>>> So I added the following line, right after the OnDestroyWindow() line:
>>>
>>> ((CMyView*)(((CMainFrame*)(AfxGetMainWnd()))->GetActiveView()))-
>>>

>>> I know it is not such an elegant solution, but at least it works.
>>> I will try now to find a more neater way to update the tree view,
>>> maybe with some kind of listeners...


>>>> On Monday, June 21, 2010 4:43 PM Joseph M. Newcomer wrote:

>>>> See below...


>>>>
>>>> ****
>>>> You're right not to like this code. It is horrible, and essentially a nightmare. The
>>>> CORRECT approach is to SendMessage to the main frame a user-defined message, e.g.,
>>>> CString propertyname;
>>>> CString newvalue;
>>>> ...fetch these from the property pane...
>>>> AfxGetMainWnd()->SendMessage(UWM_PROPERTY_CHANGED,
>>>> (LPARAM)&propertyname,
>>>> (WPARAM)&newvalue);
>>>> and stop right there.
>>>>
>>>> What I would probably do in the mainframe is send the message to the current view, which
>>>> would call a method of the CDocument-class,
>>>> void CMyDocument::SetProp(const CString & propname, const CString & value);
>>>> and let it worry about what gets set.
>>>>

>>>> The downside is that every view has to have a handler for this message, since you do not


>>>> know which view might be active.
>>>>
>>>> LRESULT OnPropertyChange(WPARAM wParam, LPARAM lParam)
>>>> {
>>>> CString * prop = (CString *)wParam;
>>>> CString * val = (CString *)lParam;
>>>> GetDocument()->SetProp(*prop, *val);
>>>> return 0;
>>>> }
>>>>
>>>> Always maintain abstraction. When you find yourself doing horrible casts and having to
>>>> include header files that you should not need, you have a bad architecture.
>>>> joe
>>>> ****

>>>> ****
>>>> I do not have a good answer for that problem. However, there are some fascinating problems


>>>> about how <enter> is handled when controls are embedded in MFC views; the classic one is
>>>> how to handle <enter> when editing a tree-control item (the code, however, is massively
>>>> buggy; I discuss this in my MSDN Errors and Omissions articles)
>>>> joe
>>>> ****

>>>> Joseph M. Newcomer [MVP]
>>>> email: newc...@flounder.com
>>>> Web: http://www.flounder.com
>>>> MVP Tips: http://www.flounder.com/mvp_tips.htm


>>>>> On Monday, June 21, 2010 4:45 PM Joseph M. Newcomer wrote:

>>>>> See below...


>>>>>
>>>>> ****
>>>>> I would have thought this was what you were *starting from*.
>>>>> ****

>>>>> ****
>>>>> As I indicated in an earilier reply, there is nothing justifiable about any part of the
>>>>> above code. You should not be casting the AfxGetMainWnd to anything, and the very
>>>>> presence of CMyView* indicates a deep design error that should not exist.
>>>>> joe
>>>>>

>>>>> Joseph M. Newcomer [MVP]
>>>>> email: newc...@flounder.com
>>>>> Web: http://www.flounder.com
>>>>> MVP Tips: http://www.flounder.com/mvp_tips.htm


>>>>> Submitted via EggHeadCafe - Software Developer Portal of Choice
>>>>> Changing WCF Service Implementation at Runtime
>>>>> http://www.eggheadcafe.com/tutorials/aspnet/d9263dcc-f7ed-42f3-bc96-321461be3306/changing-wcf-service-implementation-at-runtime.aspx

0 new messages