Eclipse validation fails with GitHub merges

[Arthur De Magalhaes]

Hey everyone,

I recently discovered that if we have a "staging" GitHub repo that collects a bunch of smaller/related PRs (ie: my fork https://github.com/arthurdm/microprofile-open-api) then that creates an issue when doing a main PR merge into an MP repo (ie: https://github.com/eclipse/microprofile-open-api/pull/17).

It seems that the Eclipse validation flags the "nor...@github.com" committer signature that gets created during a GitHub merge. Here's the message: https://dev.eclipse.org/eclipse-webhook/services/status_details.php?id=59f2470ee0396

I opened a bugzilla report for this (https://bugs.eclipse.org/bugs/show_bug.cgi?id=526426), so just wanted to bring this to the group's attention in case someone else is hitting it - or if someone knows of a workaround.

Thx,

Arthur

[Andy Guibert]

Hi Arthur,

All of the commits in your PR (of which there are 27) need to be signed-off-by a users who have signed the ECA.  You can check whether or not an email has signed the ECA here: https://accounts.eclipse.org/user/373291/eca

The eclipse validation isn't very descriptive when things go wrong (so the bug you opened is valid imo).  However, I think what's going wrong under the covers is some of the commits are not signed off at all, and some are signed off by users who have not signed the ECA.

[Emily Jiang]

Andy was right. I took a look at the commits. Some commits with red cross has no signoff, which is why your PR failed ip validation check. The commits from Michael Glavassevich were signed off. Your commits have no signoff. You need to use -s to sign off when you commit.

Emily

[Arthur De Magalhaes]

Right -  previously we had some team members who didn't have the ECA signed or the commit signed, but we got that all fixed up.   Notice that the only X marks are in the PR merges (not in regular commits), and this page only complains about "nor...@github.com", not about anyone in particular.  https://dev.eclipse.org/eclipse-webhook/services/status_details.php?id=59ef64a19891f

[Emily Jiang]

By the way, you need to make sure your eclipse account has the github id populated correctly.

Emily

[Arthur De Magalhaes]

Yup, got that too.     I really think it's an issue with the eclipse validation not liking the auto-commit that gets created when you use GitHub's PR merge (which gets attributed to the non-ECA "nor...@github.com" account instead of the merger's account) in a branch *before* doing a PR into a main eclipse MP repo.  

If anyone wants to re-create this:

- fork any MP repo into your own GitHub account (ie: myAcct/repo)

- create another branch inside that fork (ie: branch "test" inside myAcct/repo) and push a signed commit into that test branch

- create a PR between "test" and "master" in myAcct/repo (now your master branch of myAcct/repo has your signed commit + an auto-generated "nor...@github.com" commit representing the merge from test into master)

- create a PR between the master branch of myAcct/repo and that original MP repo you forked from, and you should see the failed eclipse validation.

If you see something different, please let me know.

- Arthur

[John D. Ament]

Also, just to point out, the ECA check is a warning, not an error.  While it fails, it's ultimately up to the community receiving the PR to decide if they have everything they need from it.  I would check that all of the contributors have ECAs on file and merge, even if the IP check fails.

The nor...@github.com issue is being solved by Eclipse Infra.  You can follow along at https://bugs.eclipse.org/bugs/show_bug.cgi?id=521596 .  They agreed they are incorrectly checking email when they should be checking github username.

John