Need CQs for Component Releases ASAP... (MP 3.0 release is in jeopardy)

62 views
Skip to first unread message

Kevin Sutter

unread,
May 22, 2019, 4:09:58 PM5/22/19
to Eclipse MicroProfile
Hi,
As part of my prep for the MicroProfile 3.0 release, I run some "mvn dependency:list" commands to see if anything has changed for our 3rd party dependencies.  The responsibility of creating the necessary CQs falls on the Component, but I just like to double check in case something falls through the cracks.


I assume the previous release is "clean".  So, I compare the list of dependencies from the previous release with the current set of dependencies and see what's different.  Each of these needs to be covered by a CQ.  Many of our API dependencies are already vetted by Eclipse and we just need to "piggy back" on the existing Approved CQ.  If the dependency is only used for build and/or testing, then you can combine these requests into a single CQ.  These CQs need to be submitted and approved before we can submit for a Release Review.  Thus, it looks like we might need to push MP 3.0 out to the middle of June.  But, let's see how quickly we can turn around these CQs before making that assessment.  If most of these are piggy-back CQs, then we still have a chance to make the original dates...

Please reference the above wiki page for more information on these definitions and other helpful hints.  Hit me up if you have additional questions about this process.

Comparing Rest Client 1.2 with 1.3: 
Clean

Comparing Metrics 1.1 with 2.0: 
> org.osgi:org.osgi.annotation.versioning:jar:1.1.0:compile  (most likely a build/test dependency)

Comparing Health 1.0 with 2.0:
> com.fasterxml.jackson.core:jackson-annotations:jar:2.2.3:compile
> com.fasterxml.jackson.core:jackson-core:jar:2.2.3:compile
> com.fasterxml.jackson.core:jackson-databind:jar:2.2.3:compile
> com.github.fge:btf:jar:1.2:compile
> com.github.fge:msg-simple:jar:1.1:compile
> com.github.fge:uri-template:jar:0.9:compile
> com.github.java-json-tools:jackson-coreutils:jar:1.9:compile
> com.github.java-json-tools:json-schema-core:jar:1.2.10:compile
> com.github.java-json-tools:json-schema-validator:jar:2.2.10:compile
> com.google.code.findbugs:jsr305:jar:3.0.1:compile
> com.google.guava:guava:jar:16.0.1:compile
> com.googlecode.libphonenumber:libphonenumber:jar:8.0.0:compile
> javax.activation:activation:jar:1.1:compile
> javax.enterprise:cdi-api:jar:2.0:provided
> javax.mail:mailapi:jar:1.4.3:compile
> joda-time:joda-time:jar:2.9.7:compile
> net.sf.jopt-simple:jopt-simple:jar:5.0.3:compile
> org.mozilla:rhino:jar:1.7.7.1:compile

Sorry this is coming in at the 11th hour...  My mistake for assuming...  Especially in the case of new Component participants on the Health Check project...

-- Kevin

Ken Finnigan

unread,
May 22, 2019, 4:13:34 PM5/22/19
to MicroProfile
I really hope most, all, those new Health Check dependencies are for testing only.

There's a large number of new dependencies there, some of which I'd argue are completely inappropriate, such as javax.mail.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile...@googlegroups.com.
To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/488d31d2-05f1-4be0-ac9f-128510aa3ad9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Kevin Sutter

unread,
May 22, 2019, 4:34:49 PM5/22/19
to Eclipse MicroProfile
Agree, Ken.  I'm thinking most are build/test or piggy-back dependencies.  And, it would be nice if we could remove some of them if they don't apply.  From the diff run, it looks like the Health Check team did remove many dependencies that were no longer required based on the 1.0 release...

-- Kevin
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile+unsubscribe@googlegroups.com.

Martin Stefanko

unread,
May 22, 2019, 5:03:04 PM5/22/19
to microprofile
In Health Check most of the new dependencies came in this PR - https://github.com/eclipse/microprofile-health/pull/175, so only for testing. However, doing "mvn dependency:tree":

[INFO] \- com.github.java-json-tools:json-schema-validator:jar:2.2.10:compile
[INFO]    +- com.github.java-json-tools:json-schema-core:jar:1.2.10:compile
[INFO]    |  +- com.github.java-json-tools:jackson-coreutils:jar:1.9:compile
[INFO]    |  |  +- com.fasterxml.jackson.core:jackson-databind:jar:2.2.3:compile
[INFO]    |  |  |  +- com.fasterxml.jackson.core:jackson-annotations:jar:2.2.3:compile
[INFO]    |  |  |  \- com.fasterxml.jackson.core:jackson-core:jar:2.2.3:compile
[INFO]    |  |  +- com.google.guava:guava:jar:16.0.1:compile
[INFO]    |  |  \- com.github.fge:msg-simple:jar:1.1:compile
[INFO]    |  |     \- com.github.fge:btf:jar:1.2:compile
[INFO]    |  +- com.github.fge:uri-template:jar:0.9:compile
[INFO]    |  \- org.mozilla:rhino:jar:1.7.7.1:compile
[INFO]    +- javax.mail:mailapi:jar:1.4.3:compile
[INFO]    |  \- javax.activation:activation:jar:1.1:compile
[INFO]    +- joda-time:joda-time:jar:2.9.7:compile
[INFO]    +- com.googlecode.libphonenumber:libphonenumber:jar:8.0.0:compile
[INFO]    +- com.google.code.findbugs:jsr305:jar:3.0.1:compile
[INFO]    \- net.sf.jopt-simple:jopt-simple:jar:5.0.3:compile

it's not all in the list. I was asking about adding new dependency on gitter and I was told it was ok if it's for testing only. Sorry for this, I will bookmark the wiki page now.

To unsubscribe from this group and stop receiving emails from it, send an email to microprofile...@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/488d31d2-05f1-4be0-ac9f-128510aa3ad9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile...@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/051bfe3b-b976-4c37-8aaa-8b5762a14a59%40googlegroups.com.

Antoine Sabot-Durand

unread,
May 22, 2019, 5:45:53 PM5/22/19
to MicroProfile
Hi Kevin,

Sorry for the issue.

As Martin said these dependencies were only brought for a test of the JSON schema in TCK.

We have 2 solutions to solve this issue:

1) We remove this test and reintroduce in the next release. Schema was in spec in 1.0 and wasn't tested so we can revert to that situation. that should remove all the new dependencies
2) Exclude all the unnecessary dependencies to have only the ones useful for the test and create the CQ for them (one CQ if I understand the doc)

case 1) can be done right away and should keep us on track for MP 3.0 release

In both case we'll have to do a new release of health Check 

Antoine Sabot-Durand


To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/CAEWhS7of0jKWQnVWm-WC7yU8YsNd%3D9Z5e4a4rqbMWnFC5fkV%2BQ%40mail.gmail.com.

Kevin Sutter

unread,
May 22, 2019, 5:57:34 PM5/22/19
to Eclipse MicroProfile
Thanks guys for the quick replies!

If we want to stick with the current MP 3.0 release, then I would suggest option #1.  Since that update would only affect the TCK, it would be relatively easy to do a 2.0.1 service release.  We wouldn't have to update the Platform spec or pom or anything (since we don't reference service releases in the Platform).

If you could start on that activity yet this evening (doesn't have to complete), then I could truthfully go forward with the MP 3.0 release since I know it's being resolved.

Sound good?
Kevin
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile+unsubscribe@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/488d31d2-05f1-4be0-ac9f-128510aa3ad9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile+unsubscribe@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/051bfe3b-b976-4c37-8aaa-8b5762a14a59%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile+unsubscribe@googlegroups.com.

Antoine Sabot-Durand

unread,
May 22, 2019, 6:04:44 PM5/22/19
to MicroProfile
Ok, I start the process right now so this evening (night for me ;-) ).



Antoine Sabot-Durand


To unsubscribe from this group and stop receiving emails from it, send an email to microprofile...@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/488d31d2-05f1-4be0-ac9f-128510aa3ad9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile...@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/051bfe3b-b976-4c37-8aaa-8b5762a14a59%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile...@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/ddc05533-8c33-48b1-9966-3e309a453622%40googlegroups.com.

Antoine Sabot-Durand

unread,
May 23, 2019, 5:06:32 AM5/23/19
to MicroProfile
 
Antoine Sabot-Durand

Kevin Sutter

unread,
May 23, 2019, 9:06:52 AM5/23/19
to Eclipse MicroProfile
Thanks, Antoine and Martin!

Thanks also for pointing out the tree view of the dependencies...  We as a project only need to consider the top-level dependencies that we pull in.  We don't have to traverse the dependency tree for the CQs.  So, I'll have to consider an alternative method of checking for new dependencies...  Thanks!

-- Kevin
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile+unsubscribe@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/488d31d2-05f1-4be0-ac9f-128510aa3ad9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile+unsubscribe@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/051bfe3b-b976-4c37-8aaa-8b5762a14a59%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile+unsubscribe@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile+unsubscribe@googlegroups.com.

Martin Stefanko

unread,
May 23, 2019, 9:13:28 AM5/23/19
to Eclipse MicroProfile
Kevin, can you keep us posted please? I would like to propose some kind of automated tool that could scan PRs and propose potential CQs problems before merging so we can proactively avoid these kind of situations in future.
To unsubscribe from this group and stop receiving emails from it, send an email to microp...@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/488d31d2-05f1-4be0-ac9f-128510aa3ad9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microp...@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/051bfe3b-b976-4c37-8aaa-8b5762a14a59%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microp...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microp...@googlegroups.com.

Kevin Sutter

unread,
May 23, 2019, 9:20:33 AM5/23/19
to Eclipse MicroProfile
Exactly!  I'm not a tools guy, but that type of automated process would be so much better!  Go ahead and create the issue now if you wish.  Use the microprofile repo.  Maybe we have some tools or maven wizards that could create this in a heartbeat...

Thanks, Kevin

Kevin Sutter

unread,
May 23, 2019, 10:49:28 AM5/23/19
to Eclipse MicroProfile
FYI...

I just talked with Heiko and the update for the org.osgi.annotation.versioning was a mistake...  There was no need to update to 1.1.0.  They are in the process of correcting this situation and respinning as well.  So, I think we're back on plan for MP 3.0... I'll submit the release review today and we should be okay.  Thanks for your quick turnaround!

-- Kevin

Emily Jiang

unread,
May 23, 2019, 11:52:07 AM5/23/19
to Eclipse MicroProfile
I don't think it was a mistake by updating to versioning plugin to 1.1.0, which was upgraded to use some annotations existing in 1.1.0.

In the future, when any component does release, can you please follow the instruction step by step (https://wiki.eclipse.org/MicroProfile/SpecRelease). The CQ requirement was documented there.

I am not sure backing out changes is a good thing as MP 3.0 just include the Metrics 2.0 and Helath Check 2.0. Can't we just do a CQ first? We need to do the CQ anyway for future releases? I will go ahead to head start to create the updated version of versioning plugin as it is very straightforward.

Thanks
Emily

Kevin Sutter

unread,
May 23, 2019, 12:13:43 PM5/23/19
to MicroProfile
Emily,
If we start the CQ for an updated dependency now it will prevent MicroProfile 3.0 from passing the release review on June 05.  Plain and simple.  It was a choice.  Revert the dependency and stick with the schedule.  Or, file a CQ and move MP 3.0 out two weeks to June 19.  That was the point of this email thread.  I was more concerned about the new dependency list for Health Check 2.0.  That was easily resolved in a 2.0.1 release.  The outstanding item was this osgi library with Metrics.  Based on the discussion in this thread plus a private discussion with Heiko determined it was better to revert the osgi version update for now.

I agree that we should start the updates for the next release and get the proper CQs in place to document the use of the updated dependencies.

Thanks,
Kevin

You received this message because you are subscribed to a topic in the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/microprofile/n01Rgj4jaTg/unsubscribe.
To unsubscribe from this group and all its topics, send an email to microprofile...@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/e6514eb3-b6bf-455a-927a-23ec80412946%40googlegroups.com.

Kevin Sutter

unread,
May 23, 2019, 12:59:48 PM5/23/19
to Eclipse MicroProfile
Martin,
Getting back to the automation aspect...  I have now experimented with the dependency tree output and associated grepping commands...

I just used them against Metrics 2.0.0, Health 2.0.1, and Rest Client 1.3 and the output all looks good.

If we could somehow automate this, it would be great.  But, TBH, even this discussion and working through the mvn and egrep commands has been helpful for me!  :-)

Thanks,
Kevin
To unsubscribe from this group and all its topics, send an email to microprofile+unsubscribe@googlegroups.com.

Martin Stefanko

unread,
May 23, 2019, 2:15:24 PM5/23/19
to Eclipse MicroProfile
Thanks Kevin, this will be helpful. I'll see what we can do :) - https://github.com/eclipse/microprofile/issues/115
To unsubscribe from this group and all its topics, send an email to microp...@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.

Emily Jiang

unread,
May 28, 2019, 5:55:21 AM5/28/19
to Eclipse MicroProfile
Hi Kevin,

I prefer to fix the issue properly. Personally I don't see the real difference between June 05 and June 19 unless someone else has.

By the way, I have filed CQ for annotation versioning 1.1 approval. https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19914
Can you or John add  +1 so that we can get it approved asap?

Thanks
Emily
To unsubscribe from this group and all its topics, send an email to microp...@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.

Kevin Sutter

unread,
May 29, 2019, 10:35:20 AM5/29/19
to Eclipse MicroProfile
I think everyone agrees that it should be fixed appropriately...  But, the train for MP 3.0 is already at the station and ready for the release review on June 5.  We already have the PMC and IP Log approvals.  I'm fine with going forward with this CQ, but it will be post MP 3.0.

Thanks!
Kevin

Emily Jiang

unread,
May 30, 2019, 6:07:42 AM5/30/19
to MicroProfile
OK, thanks. That's fine.
In the next releases, we need to reinforce the CQ issues when anyone announces their first RC1. I think it is better to do CQ whenever a new plugin or new version of plugin appears in PRs. The group should proactively raise the relevant CQs to prevent from further release delays.

Thanks
Emily

To unsubscribe from this group and all its topics, send an email to microprofile...@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/8ab23dbc-76ab-4f4b-b99b-dafbddf33850%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.


--
Thanks
Emily
=================
Emily Jiang
eji...@apache.org
Reply all
Reply to author
Forward
0 new messages