MicroProfile API jars & module-info.java — is it ok to propose a fix?

[ant...@sabot-durand.net]

Hi all,

Quick one from the Vidocq side (you know the drill by now — strict Java Modules everywhere, no automatic modules, no classpath fallback 🙂).

While wiring up the MicroProfile bricks, we hit the usual annoyance: Jakarta EE API jars are properly modularized these days, but the MicroProfile ones (Config, Health, Metrics, Fault Tolerance, JWT Auth, REST Client, Telemetry, OpenAPI) still don't ship a module-info.java. We ended up repackaging each of them ourselves just to add the descriptor, which works for us but obviously isn't a great story for anyone else wanting real java module support on MicroProfile.

Before opening actual issues/PRs, wanted to float it here first:

• Anyone already looked into this / know why it hasn't happened yet? (split packages, Automatic-Module-Name habits people rely on, etc.)

• Any objection to us just doing the work?

We're happy to prepare PRs for each spec's API jar with the module descriptors, following whatever naming/exports convention people prefer. Thanks for your feedback and thoughts on this topic

Regards,

Antoine Sabot-Durand

[Roberto Cortez]

Hi Antoine,

There's work underway in Quarkus to support modules. We also had some issues, and we have been adding either the Automatic Module name, or the actual descriptor:

- https://github.com/microprofile/microprofile-config/pull/810

- https://github.com/microprofile/microprofile-context-propagation/pull/222

I believe there may be other specs with something, but I didn’t check them all.

Please feel free to propose PRs. I’m more than happy to review.

Thank you!

Cheers,

Roberto

--
You received this message because you are subscribed to the Google Groups "MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/microprofile/fc5fd6dd-a1f1-4deb-bd96-ae1232270fcan%40googlegroups.com.

[ant...@sabot-durand.net]

Hi Roberto,

Thanks for your answer. If we want to enable jlink image generation, we really need explicit modules definition. To be sure I follow the right process, I already submitted an issue on mp-config : https://github.com/microprofile/microprofile-config/issues/815.

If it's ok for you I'm ready to create the PR. The module definition we propose have already been tested in vidocq with ou mp api repackaging.

Regards,

Antoine

[Emily Jiang]

Great to hear from you, Antoine! Welcome back! Feel free to create issues and PRs to address the need.

Thanks

Emily

To view this discussion visit https://groups.google.com/d/msgid/microprofile/993390e4-5af2-4b6e-bd4c-01a093f783e7n%40googlegroups.com.

--

Thanks
Emily

[ant...@sabot-durand.net]

Hi Emily,

Happy to be back and help the stack a little bit  I created issues and PR on the topic, but discovered in process that it was more complicated than expected ;-). I'll start a thread to launch discussion on a few points.

Regards,

Antoine Sabot-Durand