Rest Client: URI vs. URL

[Harald Wellmann]

Playing around with the Rest Client (using WildFly 12.0.0.Beta1), I came across

    RestClientBuilder baseUrl(URL url);

which is a bit of a surprise, given that JAX-RS normally uses URI instead of URL, so I would have expected

    RestClientBuilder baseUri(URI uri);

instead, or at least as an alternative.

My main concern is not about the subtle logical differences between URIs and URLs, but about spurious conversions and unchecked vs. checked exceptions (e.g. MalformedURLException).

What was the motivation for using URL in this API signature?

Regards,
Harald

[Werner Keil]

Good point. Hopefully these kind of inconsistencies can be fixed when the project merges with EE4J ;-)

Regards,

Werner

[Craig McClanahan]

IIRC, there is also a pretty substantial performance penalty for using URL, as it actually tries to resolve this to a real destination, while URI is just concerned with the syntax.

Craig McClanahan

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile+unsubscribe@googlegroups.com.
To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/523300a9-3891-4588-b805-fdd5f1bd2c09%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Emily Jiang]

Adding baseURI() sounds good. I think it is best to open an issue on the repo https://github.com/eclipse/microprofile-rest-client/.

Emily

On Sunday, February 18, 2018 at 11:53:17 PM UTC, Craig McClanahan wrote:

IIRC, there is also a pretty substantial performance penalty for using URL, as it actually tries to resolve this to a real destination, while URI is just concerned with the syntax.

Craig McClanahan

On Sun, Feb 18, 2018 at 3:43 AM, Harald Wellmann <hwellm...@gmail.com> wrote:

Playing around with the Rest Client (using WildFly 12.0.0.Beta1), I came across

    RestClientBuilder baseUrl(URL url);

which is a bit of a surprise, given that JAX-RS normally uses URI instead of URL, so I would have expected

    RestClientBuilder baseUri(URI uri);

instead, or at least as an alternative.

My main concern is not about the subtle logical differences between URIs and URLs, but about spurious conversions and unchecked vs. checked exceptions (e.g. MalformedURLException).

What was the motivation for using URL in this API signature?

Regards,
Harald

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.

To unsubscribe from this group and stop receiving emails from it, send an email to microprofile...@googlegroups.com.

[Harald Wellmann]

For the record, I've created an issue here:

https://github.com/eclipse/microprofile-rest-client/issues/76

Regards,

Harald

To unsubscribe from this group and stop receiving emails from it, send an email to microprofile+unsubscribe@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/7490192d-be7f-487b-bcb4-cbaf8df6faf4%40googlegroups.com.

[Andy McCright]

Thanks Harald - we'll try to get that put in to the 1.1 release.