Release MP-OpenTracing 1.2

38 views
Skip to first unread message

Pavol Loffay

unread,
Sep 10, 2018, 4:34:22 AM9/10/18
to Eclipse MicroProfile
Hello, 

I have released MP-OpenTracing RC [1] [2]. Please review so we can do full release on Friday or Monday.




Regards,

Kevin Sutter

unread,
Sep 10, 2018, 3:44:06 PM9/10/18
to Eclipse MicroProfile
A couple of nits, Pavol...

o  The github issue links referenced on the github 1.2-RC page are not formatted correctly.  I get 404 errors when I click on them.  Of course, I can modify the resulting URL and get to the desired information, but we should clean those up for people that are not as comfortable with the information.

o  The reference to "geronimo-antinject" should actually be "geronimo-atinject"

o In the future, I would number your RC.  If you need to respin and call the next one RC2, then this lack of a number implicitly becomes RC1, but I would number it from the beginning.

o  I would also include the version in the naming of your .html and .pdf files for your specs.  Most of the other specs do this already via the pom file configuration.  Here's an example of the platform microprofile spec: 

Thanks!
Kevin

Pavol Loffay

unread,
Sep 12, 2018, 9:29:51 AM9/12/18
to Eclipse MicroProfile
Thanks for the nits Kev. 

The versioning is useful I will do it for the next version. 

I have just noticed the formatting in the release page.  I will probably remove the changelog from the RC and keep it only for a final version. It seems that copy-paste from adoc does not work as expected :). 


I will fix these and produce RC2


Also adding an example of passing TCK with produced RC https://github.com/smallrye/smallrye-opentracing/pull/23

Pavol Loffay

unread,
Sep 12, 2018, 11:23:58 AM9/12/18
to Eclipse MicroProfile
Reply all
Reply to author
Forward
0 new messages