MicroProfile 2.0.1-RC3 Review Request (final RC???)

25 views
Skip to first unread message

Kevin Sutter

unread,
Jul 19, 2018, 7:45:57 PM7/19/18
to Eclipse MicroProfile
Hi,
I hope this is the final RC for 2.0.1...  Please take a review and provide a +1 if you are okay with it.  We need to finalize this release to allow some queued up changes to get properly merged...  Thanks!

https://github.com/eclipse/microprofile/releases/tag/2.0.1-RC3

-- Kevin

Emily Jiang

unread,
Jul 22, 2018, 5:58:33 PM7/22/18
to Eclipse MicroProfile
Looks good! Thanks Kevin!
Emily

Kevin Sutter

unread,
Jul 24, 2018, 2:55:15 PM7/24/18
to Eclipse MicroProfile
I'd like to get some additional +1's before calling 2.0.1 complete...  I know the Ondro has some changes backed up until I get this release finalized.  So, please take a look and give me a thumbs up to finalize this release.  Thanks!

(I am on vacation this week, but I will check in once in a while so that the release can be finalized.  Thanks.)

--  Kevin

Edwin Derks

unread,
Jul 24, 2018, 3:03:12 PM7/24/18
to Eclipse MicroProfile
Hi Kevin,

I scanned the contents again and it looks good to me. Congratz, 2.0.1 is a big and important step in the evolution of MP. :)

Gr,

Edwin

Daniel Dias Dos Santos

unread,
Jul 24, 2018, 3:08:47 PM7/24/18
to microp...@googlegroups.com
+1 , thanks 
--
Daniel Dias dos Santos
Java Developer
SouJava & JCP Member
Linkedin: http://br.linkedin.com/in/danieldiassantos


--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile...@googlegroups.com.
To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/4cc56e0d-b5a0-4dfd-9c2e-75ad3504f269%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Alasdair Nottingham

unread,
Jul 24, 2018, 10:04:26 PM7/24/18
to microp...@googlegroups.com
The only feedback I can see is on the github release page, not the content. The GitHub release page says you can get started by adding this dependency into you pom:

<dependency>
    <groupId>org.eclipse.microprofile</groupId>
    <artifactId>microprofile</artifactId>
    <version>2.0.1</version>
    <type>pom</type>
</dependency>

however the spec itself says:

<dependency>
    <groupId>org.eclipse.microprofile</groupId>
    <artifactId>microprofile</artifactId>
    <version>2.0.1</version>
    <type>pom</type>
    <scope>provided</scope>
</dependency>

The difference is the scope in the pdf is set to provided. I suspect this should be consistent and I’d vote to having the github release page follow the pdf.

Alasdair

Ondro Mihályi

unread,
Jul 25, 2018, 2:00:49 PM7/25/18
to Eclipse MicroProfile
I don't want to delay this release, so I'm giving +1.

But I have a remark: Do we really want to increase the release counter with this patch release? The spec for MP 2.0 says it's the "sixth" release and the spec for MP 2.0.1 says it's the "seventh" release. Furthermore, the spec only mentions 2.0.1 and 2.0 releases while saying it's the seventh release, totally confusing. I would completely drop counting of the releases from the spec. It's confusing and not even relevant. People don't really care now, almost 2 years since MP 1.0.

Everything else seems to be fine.

--Ondro

Kevin Sutter

unread,
Jul 26, 2018, 9:45:48 AM7/26/18
to Eclipse MicroProfile
Ondro,
I completely agree with you.  I was contemplating removing the counting while donig this 2.0.1 patch release, but I decided not to disturb the process while doing this simple release...  Next release, we'll get rid of the counting.  Thanks for confirming!

--  Kevin

Kevin Sutter

unread,
Jul 26, 2018, 9:46:24 AM7/26/18
to Eclipse MicroProfile
Thanks for the catch, Alasdair!  I'll modify the release notes accordingly.

--  Kevin


On Tuesday, July 24, 2018 at 9:04:26 PM UTC-5, Alasdair Nottingham wrote:
The only feedback I can see is on the github release page, not the content. The GitHub release page says you can get started by adding this dependency into you pom:

<dependency>
    <groupId>org.eclipse.microprofile</groupId>
    <artifactId>microprofile</artifactId>
    <version>2.0.1</version>
    <type>pom</type>
</dependency>

however the spec itself says:

<dependency>
    <groupId>org.eclipse.microprofile</groupId>
    <artifactId>microprofile</artifactId>
    <version>2.0.1</version>
    <type>pom</type>
    <scope>provided</scope>
</dependency>

The difference is the scope in the pdf is set to provided. I suspect this should be consistent and I’d vote to having the github release page follow the pdf.

Alasdair
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile+unsubscribe@googlegroups.com.

To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/4cc56e0d-b5a0-4dfd-9c2e-75ad3504f269%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile+unsubscribe@googlegroups.com.

Kevin Sutter

unread,
Jul 26, 2018, 9:52:27 AM7/26/18
to Eclipse MicroProfile
I'm kicking off the final 2.0.1 build...  Thanks for the reviews!
Reply all
Reply to author
Forward
0 new messages