Genie-microprofile asks "Can one of the admins verify this patch?" - what now?

[Heiko Rupp]

Sometimes Jenkins asks "Can one of the admins verify this patch?"

( e.g. here: 7 minutes ago )

What does it want and what options do I have? I quickly looked at the Eclipse Project Handbook, but did not find it answered there

[Ladislav Thon]

Seems you already figured that out, but "Can one of the admins verify this patch?" suggests it's GitHub Pull Request Builder plugin. The beginning of the README has the answers: https://github.com/jenkinsci/ghprb-plugin/

LT

út 20. 11. 2018 v 15:41 odesílatel 'Heiko Rupp' via Eclipse MicroProfile <microp...@googlegroups.com> napsal:

Sometimes Jenkins asks "Can one of the admins verify this patch?"

( e.g. here: 7 minutes ago )

What does it want and what options do I have? I quickly looked at the Eclipse Project Handbook, but did not find it answered there

--
You received this message because you are subscribed to the Google Groups "Eclipse MicroProfile" group.
To unsubscribe from this group and stop receiving emails from it, send an email to microprofile...@googlegroups.com.
To post to this group, send email to microp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/10bd3878-d50b-4558-8b2b-bd76013d071c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Heiko Rupp]

Well, it looks like that builder, but then Genie did not do anything with my comment - which is why I am asking here.

[Emily Jiang]

It means MicroProfile-metrics has switched on the automatic build. Basically whenever you do a PR, a build will be kicked off. If it passed, you will get this message you posted. If the build fails, you will get an error message.

Thanks

Emily

[Heiko Rupp]

I don't think so Emily, as I think we only get that message when the PR is from some "outsider" (non-committer?).

We don't always get this on every PR.

[Ladislav Thon]

GHPRB has a whitelist for each Jenkins job, and if the PR author is on the whitelist, the PR is built without approving.

LT

čt 22. 11. 2018 v 11:43 odesílatel 'Heiko Rupp' via Eclipse MicroProfile <microp...@googlegroups.com> napsal:

To view this discussion on the web visit https://groups.google.com/d/msgid/microprofile/571545d9-9522-4364-af7c-8aaf195e8b2d%40googlegroups.com.