Best way to get a Pull Request merged?

[Diego Medina]

Hi,

I recently run into an issue at work where running a normal count() with a query runs a lot slower than if I pass a hint to use a particular index, (this running on the mongo command line, and then I found out that mgo ignores the hint parameter for counts

https://github.com/go-mgo/mgo/issues/364

looks like a simple enough change for me to submit, but I saw there are several PRs still pending approval on the repo, so I was wondering if there is anything in particular I should do to make your (maintainer's) life easier with this PR.

Also, should I send the PR against stable v1 or unstable v2? (at work we are on v1)

Thank you.

[Gustavo Niemeyer]

Hi Diego,

Yes, a PR for this is welcome assuming one is not yet available.

There isn't much to do other than submitting the PR. Things are sitting in the queue because my focus has been elsewhere in the last few months, but I'm hoping to do a release soonish, and I always walk through pending items when I do that.

The PR should be against v2-unstable, please.

--
You received this message because you are subscribed to the Google Groups "mgo-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mgo-users+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

gustavo @ http://niemeyer.net

[Diego Medina]

great, thanks! I'll be sending one this week/weekend.

--
You received this message because you are subscribed to a topic in the Google Groups "mgo-users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mgo-users/9BMkaObbKg4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to mgo-users+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Diego Medina
Lift/Scala Consultant
di...@fmpwizard.com
https://blog.fmpwizard.com/

[Diego Medina]

This ended up taking a lot longer, but I finally put time aside to send a PR

https://github.com/go-mgo/mgo/pull/461

It adds Hint and also MaxTimeMS to Count() (we are using both at work now)

I'll send a follow up email because I noticed all PRs are failing for the mongodb versions earlier than 2.6, but I found a solution which is included in my PR, but I will send a separate one in so it can be merged faster and help others.

Thanks

Diego

On Tuesday, January 10, 2017 at 12:49:33 AM UTC-5, Diego Medina wrote:

great, thanks! I'll be sending one this week/weekend.

On Mon, Jan 9, 2017 at 4:54 AM, Gustavo Niemeyer <gus...@niemeyer.net> wrote:

Hi Diego,

Yes, a PR for this is welcome assuming one is not yet available.

There isn't much to do other than submitting the PR. Things are sitting in the queue because my focus has been elsewhere in the last few months, but I'm hoping to do a release soonish, and I always walk through pending items when I do that.

The PR should be against v2-unstable, please.

On Wed, Jan 4, 2017 at 11:33 AM, Diego Medina <fmpw...@gmail.com> wrote:

Hi,

I recently run into an issue at work where running a normal count() with a query runs a lot slower than if I pass a hint to use a particular index, (this running on the mongo command line, and then I found out that mgo ignores the hint parameter for counts

https://github.com/go-mgo/mgo/issues/364

looks like a simple enough change for me to submit, but I saw there are several PRs still pending approval on the repo, so I was wondering if there is anything in particular I should do to make your (maintainer's) life easier with this PR.

Also, should I send the PR against stable v1 or unstable v2? (at work we are on v1)

Thank you.

--
You received this message because you are subscribed to the Google Groups "mgo-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to mgo-users+...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

gustavo @ http://niemeyer.net

--
You received this message because you are subscribed to a topic in the Google Groups "mgo-users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mgo-users/9BMkaObbKg4/unsubscribe.

To unsubscribe from this group and all its topics, send an email to mgo-users+...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.