Cartridge v5.0.0-rc.1

[Joseph Mohan]

Is anybody currently working on bringing cartridge inline with mezzanine v5.0.0-rc.1

If not, I'm happy to submit a PR, although having issues following the contribution instructions from https://github.com/stephenmcd/cartridge#contributing

I'm unable to run:

python setup.py develop 

And install the current master branch of mezzanine. I've tried changing cartridge/project_template/requirements.txt to 

Mezzanine==5.0.0a1 and Mezzanine==9999.dev0

But I'm not really sure what I'm doing here (out of touch with python package management). Do I even need to bother with this step? The changes are all pretty simple import changes.

BTW My changes in cartridge are working with the current master branch of mezzanine installed by :

pip install git+https://github.com/stephenmcd/mezzanine

Is this also correct?

Not actually contributed to a public project before so forgive me if there's follow up questions I apoligise in advance. 

Joe

[Danny]

There's an open pull request from petedermott here which does a lot of the preliminary work: https://github.com/stephenmcd/cartridge/pull/346

You could potentially look at his fork along with your other changes to get Cartridge up to date.

(I'm using a highly customised version of Cartridge for my site, but I made use of Pete's work to update my own repo to get my custom Cartridge working with Mezzanine 5.0.0-alpha1 and Django 2.2.x)

Hope this helps.

Seeya. Danny.

--
You received this message because you are subscribed to the Google Groups "Mezzanine Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mezzanine-use...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mezzanine-users/f1dda0e3-842f-493f-8155-2c038362c099n%40googlegroups.com.

[Joseph Mohan]

Thanks Danny, that was the way to go

https://github.com/stephenmcd/mezzanine/discussions/2004